From: Tom Tromey <tromey@adacore.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH v2 0/6] [gdb/symtab] Fix data-races in gdb.base/index-cache.exp
Date: Wed, 02 Aug 2023 13:44:27 -0600 [thread overview]
Message-ID: <873511dyas.fsf@tromey.com> (raw)
In-Reply-To: <20230802095305.3668-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 2 Aug 2023 11:52:59 +0200")
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
Thanks for this series. I read through it and sent a few notes.
Tom> There's one more patch like that, I checked using pahole that the struct size
Tom> is not increased.
"ptype/o" is basically pahole FWIW.
I tend to think that in most cases, the size of objects doesn't really
matter. I mean, obviously we don't want to bloat them unnecessarily,
but for something like this, I just wouldn't worry much... and if we did
care there's probably some other way we could shrink them than worrying
about packing.
In the olden days pretty much the only thing really worth worrying about
was partial symbols. Now I guess it would be cooked_index_entry.
Tom
next prev parent reply other threads:[~2023-08-02 19:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 9:52 Tom de Vries
2023-08-02 9:53 ` [PATCH v2 1/6] [gdb/symtab] Fix data race on index_cache::m_enabled Tom de Vries
2023-08-02 19:29 ` Tom Tromey
2023-08-04 0:08 ` Tom de Vries
2023-08-02 9:53 ` [PATCH v2 2/6] [gdb/symtab] Fix data race on bfd::{cacheable,format} Tom de Vries
2023-08-02 19:32 ` Tom Tromey
2023-08-04 0:09 ` Tom de Vries
2023-08-04 15:57 ` Tom Tromey
2023-08-02 9:53 ` [PATCH v2 3/6] [gdb/symtab] Fix race on dwarf2_per_cu_data::{queued,is_debug_type} Tom de Vries
2023-08-02 19:34 ` [PATCH v2 3/6] [gdb/symtab] Fix race on dwarf2_per_cu_data::{queued, is_debug_type} Tom Tromey
2023-08-02 9:53 ` [PATCH v2 4/6] [gdb/symtab] Fix data race on bfd_last_cache Tom de Vries
2023-08-02 19:37 ` Tom Tromey
2023-08-03 14:04 ` Tom de Vries
2023-08-02 9:53 ` [PATCH v2 5/6] [gdb/symtab] Fix data race on dwarf2_per_cu_data::{m_header_read_in,is_debug_type} Tom de Vries
2023-08-02 19:39 ` [PATCH v2 5/6] [gdb/symtab] Fix data race on dwarf2_per_cu_data::{m_header_read_in, is_debug_type} Tom Tromey
2023-08-02 9:53 ` [PATCH v2 6/6] [gdb/testsuite] Extend gdb.base/index-cache.exp Tom de Vries
2023-08-02 19:41 ` Tom Tromey
2023-08-02 19:44 ` Tom Tromey [this message]
2023-08-04 0:14 ` [PATCH v2 0/6] [gdb/symtab] Fix data-races in gdb.base/index-cache.exp Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873511dyas.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).