* [PATCH] Fix "usage" errors for some MI varobj commands
@ 2023-08-31 18:00 Tom Tromey
2023-08-31 22:03 ` Kevin Buettner
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2023-08-31 18:00 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
I noticed that the "usage" error for -var-set-frozen mentioned the
wrong command name. Then I looked through the whole file and found a
couple other spots that didn't mention the command name at all. This
patch fixes all of these.
---
gdb/mi/mi-cmd-var.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gdb/mi/mi-cmd-var.c b/gdb/mi/mi-cmd-var.c
index 095790a36c4..8b4dd6d0c96 100644
--- a/gdb/mi/mi-cmd-var.c
+++ b/gdb/mi/mi-cmd-var.c
@@ -246,7 +246,7 @@ mi_cmd_var_set_visualizer (const char *command, const char *const *argv,
struct varobj *var;
if (argc != 2)
- error (_("Usage: NAME VISUALIZER_FUNCTION."));
+ error (_("-var-set-visualizer: Usage: NAME VISUALIZER_FUNCTION."));
var = varobj_get_handle (argv[0]);
@@ -263,7 +263,7 @@ mi_cmd_var_set_frozen (const char *command, const char *const *argv, int argc)
bool frozen;
if (argc != 2)
- error (_("-var-set-format: Usage: NAME FROZEN_FLAG."));
+ error (_("-var-set-frozen: Usage: NAME FROZEN_FLAG."));
var = varobj_get_handle (argv[0]);
@@ -442,7 +442,7 @@ mi_cmd_var_info_path_expression (const char *command, const char *const *argv,
struct varobj *var;
if (argc != 1)
- error (_("Usage: NAME."));
+ error (_("-var-info-path-expression: Usage: NAME."));
/* Get varobj handle, if a valid var obj name was specified. */
var = varobj_get_handle (argv[0]);
--
2.40.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix "usage" errors for some MI varobj commands
2023-08-31 18:00 [PATCH] Fix "usage" errors for some MI varobj commands Tom Tromey
@ 2023-08-31 22:03 ` Kevin Buettner
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Buettner @ 2023-08-31 22:03 UTC (permalink / raw)
To: Tom Tromey via Gdb-patches; +Cc: Tom Tromey
On Thu, 31 Aug 2023 12:00:12 -0600
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> wrote:
> I noticed that the "usage" error for -var-set-frozen mentioned the
> wrong command name. Then I looked through the whole file and found a
> couple other spots that didn't mention the command name at all. This
> patch fixes all of these.
LGTM.
Reviewed-by: Kevin Buettner <kevinb@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-31 22:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-31 18:00 [PATCH] Fix "usage" errors for some MI varobj commands Tom Tromey
2023-08-31 22:03 ` Kevin Buettner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).