public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Abdul Basit Ijaz <abdul.b.ijaz@intel.com>
To: gdb-patches@sourceware.org
Cc: abdul.b.ijaz@intel.com, tom@tromey.com, kevinb@redhat.com
Subject: [PATCH 0/1] Fix regression in gdb.fortran/array-slices-bad.exp
Date: Sat,  9 Sep 2023 00:51:02 +0200	[thread overview]
Message-ID: <20230908225103.26798-1-abdul.b.ijaz@intel.com> (raw)

From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>

Got a regression email due to merge of commit in CI config
tcwg_gdb_check/master-aarch64 :
https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=41439185cd0075bbb1aedf9665685dba0827cfec

Begining of test "gdb.fortran/array-slices-bad.exp" was updated in above
commit to start the test from running to line with tag "First Breakpoint"
instead of "fortran_runto_main".  Reason of the regression is shared
libraries are still loaded after hitting the breakpoint as "nosharedlibrary"
is already called before hitting the breakpoint.

So now after this change test is updated accordingly to disable and unload
shared libraries symbols after hitting the first breakpoint.

Regression email shows following fails:

Running gdb:gdb.fortran/array-slices-bad.exp ...
FAIL: gdb.fortran/array-slices-bad.exp: print array (0,:)
FAIL: gdb.fortran/array-slices-bad.exp: print array (0:,:)
FAIL: gdb.fortran/array-slices-bad.exp: print array (10:1:1,:)
FAIL: gdb.fortran/array-slices-bad.exp: print array (11,:)
FAIL: gdb.fortran/array-slices-bad.exp: print array (1:10:-1,:)
FAIL: gdb.fortran/array-slices-bad.exp: print array (:,0)
FAIL: gdb.fortran/array-slices-bad.exp: print array (:,0:) ... and 7 more entries

After the change now all tests should pass again.  Here are the results
on Ubuntu22 and gfortran-11-4-0:

(gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (0:,:)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (:11,:)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (:,0:)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (:,:11)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (0,:)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (11,:)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (:,0)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (:,11)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (0:,:)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (:11,:)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (:,0:)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (:,:11)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (0,:)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (11,:)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (:,0)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (:,11)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print other (0:,:)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print other (:11,:)
(gdb) PASS: gdb.fortran/array-slices-bad.exp: print other (:,:11)
..

Thanks & Best Regards
Abdul Basit

Ijaz, Abdul B (1):
  testsuite, fortran: Fix regression due to fix for ifort's 'start'
    behavior

 gdb/testsuite/gdb.fortran/array-slices-bad.exp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

-- 
2.34.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


             reply	other threads:[~2023-09-08 22:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-08 22:51 Abdul Basit Ijaz [this message]
2023-09-11  9:52 ` Andrew Burgess
2023-09-11  9:59   ` Ijaz, Abdul B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230908225103.26798-1-abdul.b.ijaz@intel.com \
    --to=abdul.b.ijaz@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).