From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 0/1] Fix regression in gdb.fortran/array-slices-bad.exp
Date: Mon, 11 Sep 2023 09:59:13 +0000 [thread overview]
Message-ID: <SA1PR11MB6846C6131A9CF871701D2766CBF2A@SA1PR11MB6846.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87leddkpe5.fsf@redhat.com>
Hi Andrew,
Yes It was failed while sending and here it was sent later today: https://sourceware.org/pipermail/gdb-patches/2023-September/202312.html
Thanks & Best Regards
Abdul Basit
-----Original Message-----
From: Andrew Burgess <aburgess@redhat.com>
Sent: Monday, September 11, 2023 11:53 AM
To: Abdul Basit Ijaz via Gdb-patches <gdb-patches@sourceware.org>; gdb-patches@sourceware.org
Cc: Ijaz, Abdul B <abdul.b.ijaz@intel.com>; tom@tromey.com
Subject: Re: [PATCH 0/1] Fix regression in gdb.fortran/array-slices-bad.exp
This email is 0/1, but I don't see a 1/1 with an actual patch anywhere.
Did it fail to send maybe?
Thanks,
Andrew
Abdul Basit Ijaz via Gdb-patches <gdb-patches@sourceware.org> writes:
> From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>
>
> Got a regression email due to merge of commit in CI config
> tcwg_gdb_check/master-aarch64 :
> https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=41439185
> cd0075bbb1aedf9665685dba0827cfec
>
> Begining of test "gdb.fortran/array-slices-bad.exp" was updated in
> above commit to start the test from running to line with tag "First Breakpoint"
> instead of "fortran_runto_main". Reason of the regression is shared
> libraries are still loaded after hitting the breakpoint as "nosharedlibrary"
> is already called before hitting the breakpoint.
>
> So now after this change test is updated accordingly to disable and
> unload shared libraries symbols after hitting the first breakpoint.
>
> Regression email shows following fails:
>
> Running gdb:gdb.fortran/array-slices-bad.exp ...
> FAIL: gdb.fortran/array-slices-bad.exp: print array (0,:)
> FAIL: gdb.fortran/array-slices-bad.exp: print array (0:,:)
> FAIL: gdb.fortran/array-slices-bad.exp: print array (10:1:1,:)
> FAIL: gdb.fortran/array-slices-bad.exp: print array (11,:)
> FAIL: gdb.fortran/array-slices-bad.exp: print array (1:10:-1,:)
> FAIL: gdb.fortran/array-slices-bad.exp: print array (:,0)
> FAIL: gdb.fortran/array-slices-bad.exp: print array (:,0:) ... and 7
> more entries
>
> After the change now all tests should pass again. Here are the
> results on Ubuntu22 and gfortran-11-4-0:
>
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (0:,:)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (:11,:)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (:,0:)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (:,:11)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (0,:)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (11,:)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (:,0)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print array (:,11)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (0:,:)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (:11,:)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (:,0:)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (:,:11)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (0,:)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (11,:)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (:,0)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print pointer2d (:,11)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print other (0:,:)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print other (:11,:)
> (gdb) PASS: gdb.fortran/array-slices-bad.exp: print other (:,:11) ..
>
> Thanks & Best Regards
> Abdul Basit
>
> Ijaz, Abdul B (1):
> testsuite, fortran: Fix regression due to fix for ifort's 'start'
> behavior
>
> gdb/testsuite/gdb.fortran/array-slices-bad.exp | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> --
> 2.34.1
>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de> Managing
> Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau Registered Office:
> Munich Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
prev parent reply other threads:[~2023-09-11 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 22:51 Abdul Basit Ijaz
2023-09-11 9:52 ` Andrew Burgess
2023-09-11 9:59 ` Ijaz, Abdul B [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR11MB6846C6131A9CF871701D2766CBF2A@SA1PR11MB6846.namprd11.prod.outlook.com \
--to=abdul.b.ijaz@intel.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).