Re: [PATCH 0/7] Rewrite gdb_bfd_openr_iovec to be type-safe

[Lancelot SIX <lsix@lancelotsix.com>]

Hi Tom,

I have sent a couple of remarks on patch 1 & patch 6.  I quickly went
through the other patches of the series and did not notice any issue.

Best,
Lancelot.

On Thu, Aug 24, 2023 at 11:12:17AM -0600, Tom Tromey via Gdb-patches wrote:
> This series rewrites gdb_bfd_openr_iovec to be type-safe.
> 
> Note that I can't really test the solib-rocm.c changes, this was done
> as a best effort.
> 
> Regression tested on x86-64 Fedora 36.
> 
> ---
> Tom Tromey (7):
>       Introduce type-safe variant of gdb_bfd_openr_iovec
>       Small constructor change to target_buffer
>       Convert mem_bfd_iovec to new type-safe gdb_bfd_openr_iovec
>       Convert target fileio to new type-safe gdb_bfd_openr_iovec
>       Convert minidebug to new type-safe gdb_bfd_openr_iovec
>       Convert solib-rocm to new type-safe gdb_bfd_openr_iovec
>       Remove old gdb_bfd_openr_iovec
> 
>  gdb/gdb_bfd.c    | 211 +++++++++++++++++++++++++++----------------------------
>  gdb/gdb_bfd.h    |  43 ++++++++----
>  gdb/minidebug.c  |  98 +++++++++++---------------
>  gdb/solib-rocm.c |  39 +++-------
>  4 files changed, 182 insertions(+), 209 deletions(-)
> ---
> base-commit: 1f08d324601ef7fd4cce3cff8f8db4a774791828
> change-id: 20230824-gdb-bfd-vec-ba7f6c1139bb
> 
> Best regards,
> -- 
> Tom Tromey <tromey@adacore.com>
>