Re: [PATCH v3 2/2] gdb: add shadowed field in '-stack-list-locals/variables' mi commands

[Lancelot SIX <lsix@lancelotsix.com>]

Hi Abdul,

I think some of the comments I had on the previous patch also apply to
this one.

> diff --git a/gdb/mi/mi-cmd-stack.c b/gdb/mi/mi-cmd-stack.c
> index e473be7d465..7e4658ef415 100644
> --- a/gdb/mi/mi-cmd-stack.c
> +++ b/gdb/mi/mi-cmd-stack.c
> @@ -559,6 +575,30 @@ list_arg_or_local (const struct frame_arg *arg, enum what_to_list what,
>  	}
>        uiout->field_stream ("value", stb);
>      }
> +
> +  /* Only for C/C++/Fortran/Ada languages, in case of variables shadowing
> +     print shadowed field after the superblock variable and only location
> +     of the variables in the innerblock.  */
> +  if ((current_language->la_language == language_c
> +       || current_language->la_language == language_cplus
> +       || current_language->la_language == language_fortran
> +       || current_language->la_language == language_ada)
> +       && !(values == PRINT_NO_VALUES && what == locals)
> +       && shadowed)
> +    {
> +      std::string file_path = arg->sym->owner.symtab->filename;
> +      size_t slash_index = file_path.find_last_of ("\\/");
> +      std::string file_name = (!file_path.empty ()
> +			       ? file_path.substr (slash_index + 1)
> +			       : "NA");
> +      uiout->field_string ("file", file_name);
> +      if (arg->sym->m_line > 0)
> +	uiout->field_unsigned ("line", arg->sym->m_line);
> +      else
> +	uiout->field_string ("line", "NA");
> +      if (already_printed)
> +	uiout->field_string ("Shadowed", "True");
                              ^
I don't use MI much, but the uppercase 'S' seems odd.  For consistency,
I think it would be better left lowercase.  WDYT?

Best,
Lancelot.

> +    }
>  }
>  
>  /* Print a list of the objects for the frame FI in a certain form,