RE: [PATCH v3 2/2] gdb: add shadowed field in '-stack-list-locals/variables' mi commands

["Ijaz, Abdul B" <abdul.b.ijaz@intel.com>]

Hi Lancelot,

> I was not sure if "True" or "true" should be used.  Looking around (with `git grep "field_string" | grep -i true` show that "true" is usualy used (see gdb/mi/mi-cmd-var.c and gdb/mi/mi-cmd-info.c).

Thanks for the feedback updating to use " ("shadowed", "true");" in V4 patch series. Thanks

Best Regards
Abdul Basit

-----Original Message-----
From: Lancelot SIX <lsix@lancelotsix.com> 
Sent: Tuesday, September 19, 2023 3:20 PM
To: Ijaz, Abdul B <abdul.b.ijaz@intel.com>
Cc: gdb-patches@sourceware.org; pedro@palves.net
Subject: Re: [PATCH v3 2/2] gdb: add shadowed field in '-stack-list-locals/variables' mi commands

On Tue, Sep 19, 2023 at 11:41:47AM +0000, Ijaz, Abdul B wrote:
> Hi Lancelot,
> 
> Thanks for the feedback, will apply the changes similar to previous patch in V4 Patch series and will use " ("shadowed", "True");"  to be consistent with other fields.
> 

Hi,

I was not sure if "True" or "true" should be used.  Looking around (with `git grep "field_string" | grep -i true` show that "true" is usualy used (see gdb/mi/mi-cmd-var.c and gdb/mi/mi-cmd-info.c).

Best,
Lancelot.

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928