From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Remove keywords from target debug printer names
Date: Thu, 21 Sep 2023 18:34:19 -0700 [thread overview]
Message-ID: <20230921183419.42e94c7c@f37-zws-nv> (raw)
In-Reply-To: <20230919170534.3918313-1-tromey@adacore.com>
On Tue, 19 Sep 2023 11:05:34 -0600
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> wrote:
> I recently checked in a patch that removed the use of the "struct"
> keyword in some spots. Doing this pointed out that the target
> delegate code preserves this keyword -- but, with C++, it does not
> really need to. This patch changes make-target-delegates.py to remove
> these keywords, and updates target-debug.h to follow. This pointed
> out that there was already one redudancy: both
> target_debug_print_struct_inferior_p and target_debug_print_inferior_p
> existed.
>
> Tested by rebuilding.
LGTM.
Reviewed-by: Kevin Buettner <kevinb@redhat.com>
prev parent reply other threads:[~2023-09-22 1:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 17:05 Tom Tromey
2023-09-22 1:34 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230921183419.42e94c7c@f37-zws-nv \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).