From: Kevin Buettner <kevinb@redhat.com>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: gdb-patches@sourceware.org, Jan Kratochvil <jan@jankratochvil.net>
Subject: Re: [PATCH] gdb/testsuite: Add relative versus absolute LD_LIBRARY_PATH test
Date: Mon, 25 Sep 2023 17:16:23 -0700 [thread overview]
Message-ID: <20230925171623.7acfa2c5@f37-zws-nv> (raw)
In-Reply-To: <20230925095710.k3xektglqa3z5v2g@octopus>
On Mon, 25 Sep 2023 10:57:10 +0100
Lancelot SIX <lsix@lancelotsix.com> wrote:
> > +extern __thread int var;
>
> I think you could replace __thread (a GCC___extension) with thread_local
> which was introduced in C11 (available in the <threads.h> header)[1].
>
> This could require adding -std=c11 to additional_flags in the .exp file
> (not sure which C standard is picked by default by different versions of
> GCC).
I've made this change for v2. In my testing on Fedora 38, it didn't seem
that additonal_flags=-std=c11 was required for gcc, but I made this change
anyway. (I'd guess that it might be necessary for some older version of
gcc.) Also, I found that testing with CC_FOR_TARGET=clang didn't work
(but not due to adding -std=c11), so I fixed that problem too.
Thanks for this suggestion!
Kevin
prev parent reply other threads:[~2023-09-26 0:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 1:22 Kevin Buettner
2023-09-25 9:57 ` Lancelot SIX
2023-09-26 0:16 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925171623.7acfa2c5@f37-zws-nv \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan@jankratochvil.net \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).