[PATCH 1/1] gdb, infrun: assertion for a possibly uninitialized variable

[PATCH 1/1] gdb, infrun: assertion for a possibly uninitialized variable

[Schimpe, Christina]

From: Mihails Strasuns <mihails.strasuns@intel.com>

It is expected that the loop will always be able to find an inferior.

Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>
---
 gdb/infrun.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/infrun.c b/gdb/infrun.c
index 4fde96800fb..a36274819d8 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -3992,6 +3992,8 @@ do_target_wait (execution_control_state *ecs, target_wait_flags options)
 	  break;
 	}
 
+  gdb_assert (selected);
+
   /* Now poll for events out of each of the matching inferior's
      targets, starting from the selected one.  */
 
-- 
2.34.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

RE: [PING][PATCH 1/1] gdb, infrun: assertion for a possibly uninitialized variable

[Schimpe, Christina]

Kindly pinging for this patch.

Christina

> -----Original Message-----
> From: Schimpe, Christina <christina.schimpe@intel.com>
> Sent: Tuesday, October 24, 2023 12:17 PM
> To: gdb-patches@sourceware.org
> Subject: [PATCH 1/1] gdb, infrun: assertion for a possibly uninitialized variable
> 
> From: Mihails Strasuns <mihails.strasuns@intel.com>
> 
> It is expected that the loop will always be able to find an inferior.
> 
> Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>
> ---
>  gdb/infrun.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/gdb/infrun.c b/gdb/infrun.c index 4fde96800fb..a36274819d8
> 100644
> --- a/gdb/infrun.c
> +++ b/gdb/infrun.c
> @@ -3992,6 +3992,8 @@ do_target_wait (execution_control_state *ecs,
> target_wait_flags options)
>  	  break;
>  	}
> 
> +  gdb_assert (selected);
> +
>    /* Now poll for events out of each of the matching inferior's
>       targets, starting from the selected one.  */
> 
> --
> 2.34.1
> 
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de> Managing
> Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson
> of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial
> Register: Amtsgericht Muenchen HRB 186928

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: [PATCH 1/1] gdb, infrun: assertion for a possibly uninitialized variable

[Tom Tromey]

>>>>> Schimpe, Christina <christina.schimpe@intel.com> writes:

> From: Mihails Strasuns <mihails.strasuns@intel.com>
> It is expected that the loop will always be able to find an inferior.

> Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>

Seems fine to me.
Approved-By: Tom Tromey <tom@tromey.com>

Tom