From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v3 10/18] Change how cooked index waits for threads
Date: Wed, 22 Nov 2023 22:32:19 -0700 [thread overview]
Message-ID: <20231122-t-bg-dwarf-reading-v3-10-fc3180de63c4@tromey.com> (raw)
In-Reply-To: <20231122-t-bg-dwarf-reading-v3-0-fc3180de63c4@tromey.com>
This changes the cooked index code to wait for threads in its
public-facing API. That is, the waits are done in cooked_index now,
and never in the cooked_index_shard. Centralizing this decision makes
it easier to wait for other events here as well.
---
gdb/dwarf2/cooked-index.c | 3 +--
gdb/dwarf2/cooked-index.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/gdb/dwarf2/cooked-index.c b/gdb/dwarf2/cooked-index.c
index 10631dccecf..b48831bb18b 100644
--- a/gdb/dwarf2/cooked-index.c
+++ b/gdb/dwarf2/cooked-index.c
@@ -405,8 +405,6 @@ cooked_index_shard::do_finalize ()
cooked_index_shard::range
cooked_index_shard::find (const std::string &name, bool completing) const
{
- wait ();
-
cooked_index_entry::comparison_mode mode = (completing
? cooked_index_entry::COMPLETE
: cooked_index_entry::MATCH);
@@ -524,6 +522,7 @@ cooked_index::get_addrmaps () const
cooked_index::range
cooked_index::find (const std::string &name, bool completing) const
{
+ wait ();
std::vector<cooked_index_shard::range> result_range;
result_range.reserve (m_vector.size ());
for (auto &entry : m_vector)
diff --git a/gdb/dwarf2/cooked-index.h b/gdb/dwarf2/cooked-index.h
index 36b734f0fb6..97f09668c7b 100644
--- a/gdb/dwarf2/cooked-index.h
+++ b/gdb/dwarf2/cooked-index.h
@@ -287,7 +287,6 @@ class cooked_index_shard
/* Return a range of all the entries. */
range all_entries () const
{
- wait ();
return { m_entries.cbegin (), m_entries.cend () };
}
@@ -460,6 +459,7 @@ class cooked_index : public dwarf_scanner_base
/* Return a range of all the entries. */
range all_entries () const
{
+ wait ();
std::vector<cooked_index_shard::range> result_range;
result_range.reserve (m_vector.size ());
for (auto &entry : m_vector)
--
2.41.0
next prev parent reply other threads:[~2023-11-23 5:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 5:32 [PATCH v3 00/18] Index DWARF in the background Tom Tromey
2023-11-23 5:32 ` [PATCH v3 01/18] Don't use objfile::intern in DWO code Tom Tromey
2023-11-23 5:32 ` [PATCH v3 02/18] Pre-read DWZ section data Tom Tromey
2023-11-23 5:32 ` [PATCH v3 03/18] Add a couple of bfd_cache_close calls Tom Tromey
2023-11-23 5:32 ` [PATCH v3 04/18] Add thread-safety to gdb's BFD wrappers Tom Tromey
2023-11-23 5:32 ` [PATCH v3 05/18] Refactor complaint thread-safety approach Tom Tromey
2023-11-23 5:32 ` [PATCH v3 06/18] Add quick_symbol_functions::compute_main_name Tom Tromey
2023-11-23 5:32 ` [PATCH v3 07/18] Add gdb::task_group Tom Tromey
2023-11-23 5:32 ` [PATCH v3 08/18] Move cooked_index_storage to cooked-index.h Tom Tromey
2023-11-23 5:32 ` [PATCH v3 09/18] Add "maint set dwarf synchronous" Tom Tromey
2023-11-23 7:02 ` Eli Zaretskii
2023-11-23 5:32 ` Tom Tromey [this message]
2023-11-23 5:32 ` [PATCH v3 11/18] Do more DWARF reading in the background Tom Tromey
2023-11-23 5:32 ` [PATCH v3 12/18] Simplify the public DWARF API Tom Tromey
2023-11-23 5:32 ` [PATCH v3 13/18] Remove two quick_symbol_functions methods Tom Tromey
2023-11-23 5:32 ` [PATCH v3 14/18] Change current_language to be a macro Tom Tromey
2023-11-23 5:32 ` [PATCH v3 15/18] Lazy language setting Tom Tromey
2023-11-23 5:32 ` [PATCH v3 16/18] Optimize lookup_minimal_symbol_text Tom Tromey
2023-11-23 5:32 ` [PATCH v3 17/18] Avoid language-based lookups in startup path Tom Tromey
2023-11-23 5:32 ` [PATCH v3 18/18] Back out some parallel_for_each features Tom Tromey
2023-11-27 15:31 ` [PATCH v3 00/18] Index DWARF in the background Tom de Vries
2023-12-10 17:19 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122-t-bg-dwarf-reading-v3-10-fc3180de63c4@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).