From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 00/18] Index DWARF in the background
Date: Sun, 10 Dec 2023 10:19:44 -0700 [thread overview]
Message-ID: <87h6kq6klr.fsf@tromey.com> (raw)
In-Reply-To: <20231122-t-bg-dwarf-reading-v3-0-fc3180de63c4@tromey.com> (Tom Tromey's message of "Wed, 22 Nov 2023 22:32:09 -0700")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> This series changes gdb to do its initial DWARF indexing in the
Tom> background.
I realized today that this series could cause a warning to be emitted
from a worker thread: cooked_index_worker::do_reading is invoked in
a worker thread, and it calls read_addrmap_from_aranges.
This is bad because warning is not thread-safe.
I have a patch to change this to use deferred_warnings and ensure that
these are emitted on the main thread. I'll send v4 sometime soon-ish.
Tom
prev parent reply other threads:[~2023-12-10 17:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 5:32 Tom Tromey
2023-11-23 5:32 ` [PATCH v3 01/18] Don't use objfile::intern in DWO code Tom Tromey
2023-11-23 5:32 ` [PATCH v3 02/18] Pre-read DWZ section data Tom Tromey
2023-11-23 5:32 ` [PATCH v3 03/18] Add a couple of bfd_cache_close calls Tom Tromey
2023-11-23 5:32 ` [PATCH v3 04/18] Add thread-safety to gdb's BFD wrappers Tom Tromey
2023-11-23 5:32 ` [PATCH v3 05/18] Refactor complaint thread-safety approach Tom Tromey
2023-11-23 5:32 ` [PATCH v3 06/18] Add quick_symbol_functions::compute_main_name Tom Tromey
2023-11-23 5:32 ` [PATCH v3 07/18] Add gdb::task_group Tom Tromey
2023-11-23 5:32 ` [PATCH v3 08/18] Move cooked_index_storage to cooked-index.h Tom Tromey
2023-11-23 5:32 ` [PATCH v3 09/18] Add "maint set dwarf synchronous" Tom Tromey
2023-11-23 7:02 ` Eli Zaretskii
2023-11-23 5:32 ` [PATCH v3 10/18] Change how cooked index waits for threads Tom Tromey
2023-11-23 5:32 ` [PATCH v3 11/18] Do more DWARF reading in the background Tom Tromey
2023-11-23 5:32 ` [PATCH v3 12/18] Simplify the public DWARF API Tom Tromey
2023-11-23 5:32 ` [PATCH v3 13/18] Remove two quick_symbol_functions methods Tom Tromey
2023-11-23 5:32 ` [PATCH v3 14/18] Change current_language to be a macro Tom Tromey
2023-11-23 5:32 ` [PATCH v3 15/18] Lazy language setting Tom Tromey
2023-11-23 5:32 ` [PATCH v3 16/18] Optimize lookup_minimal_symbol_text Tom Tromey
2023-11-23 5:32 ` [PATCH v3 17/18] Avoid language-based lookups in startup path Tom Tromey
2023-11-23 5:32 ` [PATCH v3 18/18] Back out some parallel_for_each features Tom Tromey
2023-11-27 15:31 ` [PATCH v3 00/18] Index DWARF in the background Tom de Vries
2023-12-10 17:19 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6kq6klr.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).