public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 1/2] gdb: remove stale comment in value_assign
Date: Mon, 18 Dec 2023 15:02:46 -0500	[thread overview]
Message-ID: <20231218200256.28489-1-simon.marchi@efficios.com> (raw)

This comment is no longer relevant, put_frame_register_bytes now accepts
the "next frame".

Change-Id: I077933a03f8bdb886f8ba10a98d1202a38bce0a9
---
 gdb/valops.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/gdb/valops.c b/gdb/valops.c
index 21b010684af1..049314cf7db5 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1193,13 +1193,6 @@ value_assign (struct value *toval, struct value *fromval)
 
     case lval_register:
       {
-	/* Figure out which frame this register value is in.  The value
-	   holds the frame_id for the next frame, that is the frame this
-	   register value was unwound from.
-
-	   Below we will call put_frame_register_bytes which requires that
-	   we pass it the actual frame in which the register value is
-	   valid, i.e. not the next frame.  */
 	frame_info_ptr next_frame = frame_find_by_id (VALUE_NEXT_FRAME_ID (toval));
 
 	int value_reg = VALUE_REGNUM (toval);

base-commit: 989ea4061f275edb85ab5de8f908be5a273bd05a
-- 
2.43.0


             reply	other threads:[~2023-12-18 20:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18 20:02 Simon Marchi [this message]
2023-12-18 20:02 ` [PATCH 2/2] gdb: use put_frame_register instead of put_frame_register_bytes in pseudo_to_concat_raw Simon Marchi
2023-12-19 15:06   ` Tom Tromey
2023-12-19 16:12     ` Simon Marchi
2023-12-19 15:05 ` [PATCH 1/2] gdb: remove stale comment in value_assign Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231218200256.28489-1-simon.marchi@efficios.com \
    --to=simon.marchi@efficios.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).