From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH 13/15] sim: riscv: fix -Wshadow=local warnings
Date: Thu, 21 Dec 2023 20:23:53 -0500 [thread overview]
Message-ID: <20231222012355.7504-13-vapier@gentoo.org> (raw)
In-Reply-To: <20231222012355.7504-1-vapier@gentoo.org>
Inline the one usage of sd in these macros to avoid possible shadowing.
---
sim/riscv/sim-main.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c
index 4d2053453950..b04d12c0de1c 100644
--- a/sim/riscv/sim-main.c
+++ b/sim/riscv/sim-main.c
@@ -48,10 +48,9 @@ static const struct riscv_opcode *riscv_hash[OP_MASK_OP + 1];
do { \
if (RISCV_XLEN (cpu) != 32) \
{ \
- SIM_DESC sd = CPU_STATE (cpu); \
TRACE_INSN (cpu, "RV32I-only " fmt, ## args); \
- sim_engine_halt (sd, cpu, NULL, sim_pc_get (cpu), sim_signalled, \
- SIM_SIGILL); \
+ sim_engine_halt (CPU_STATE (cpu), cpu, NULL, sim_pc_get (cpu), \
+ sim_signalled, SIM_SIGILL); \
} \
} while (0)
@@ -59,10 +58,9 @@ static const struct riscv_opcode *riscv_hash[OP_MASK_OP + 1];
do { \
if (RISCV_XLEN (cpu) != 64) \
{ \
- SIM_DESC sd = CPU_STATE (cpu); \
TRACE_INSN (cpu, "RV64I-only " fmt, ## args); \
- sim_engine_halt (sd, cpu, NULL, sim_pc_get (cpu), sim_signalled, \
- SIM_SIGILL); \
+ sim_engine_halt (CPU_STATE (cpu), cpu, NULL, sim_pc_get (cpu), \
+ sim_signalled, SIM_SIGILL); \
} \
} while (0)
--
2.43.0
next prev parent reply other threads:[~2023-12-22 1:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 1:23 [PATCH 01/15] sim: aarch64: " Mike Frysinger
2023-12-22 1:23 ` [PATCH 02/15] sim: arm: " Mike Frysinger
2023-12-22 1:23 ` [PATCH 03/15] sim: bfin: " Mike Frysinger
2023-12-22 1:23 ` [PATCH 04/15] sim: common: " Mike Frysinger
2023-12-22 1:23 ` [PATCH 05/15] sim: cris: " Mike Frysinger
2023-12-22 1:23 ` [PATCH 06/15] sim: erc32: " Mike Frysinger
2023-12-22 1:23 ` [PATCH 07/15] sim: frv: " Mike Frysinger
2023-12-22 1:23 ` [PATCH 08/15] sim: h8300: " Mike Frysinger
2023-12-22 1:23 ` [PATCH 09/15] sim: iq2000: " Mike Frysinger
2023-12-22 1:23 ` [PATCH 10/15] sim: m68hc11: " Mike Frysinger
2023-12-22 1:23 ` [PATCH 11/15] sim: mips: " Mike Frysinger
2023-12-22 1:23 ` [PATCH 12/15] sim: ppc: " Mike Frysinger
2023-12-22 1:23 ` Mike Frysinger [this message]
2023-12-22 1:23 ` [PATCH 14/15] sim: sh: " Mike Frysinger
2023-12-22 1:23 ` [PATCH 15/15] sim: warnings: enable -Wshadow=local Mike Frysinger
2023-12-22 15:26 ` Tom Tromey
2023-12-23 4:28 ` [PATCH] sim: m32c: fix -Wshadow=local warnings Mike Frysinger
2023-12-23 4:28 ` [PATCH] sim: cris: disable -Wshadow=local in generated mloop files Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231222012355.7504-13-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).