From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH/committed] sim: ppc: igen: fix -G handling
Date: Thu, 21 Dec 2023 21:06:02 -0500 [thread overview]
Message-ID: <20231222020602.10361-1-vapier@gentoo.org> (raw)
We weren't using the enable_p flag to see whether the option should
be enabled or disabled, and we weren't breaking out when done parsing.
---
sim/ppc/igen.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/sim/ppc/igen.c b/sim/ppc/igen.c
index 8aa19c757f59..9f642440541e 100644
--- a/sim/ppc/igen.c
+++ b/sim/ppc/igen.c
@@ -439,15 +439,22 @@ main(int argc,
{
case '=':
icache_size = atoi (argp + strlen ("gen-icache") + 1);
- code |= generate_with_icache;
+ if (enable_p)
+ code |= generate_with_icache;
+ else
+ code &= ~generate_with_icache;
break;
case '\0':
- code |= generate_with_icache;
+ if (enable_p)
+ code |= generate_with_icache;
+ else
+ code &= ~generate_with_icache;
break;
default:
error ("Expecting -Ggen-icache or -Ggen-icache=<N>\n");
}
}
+ break;
}
case 'I':
{
--
2.43.0
reply other threads:[~2023-12-22 2:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231222020602.10361-1-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).