public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH/committed] sim: ppc: igen: fix -G handling
@ 2023-12-22  2:06 Mike Frysinger
  0 siblings, 0 replies; only message in thread
From: Mike Frysinger @ 2023-12-22  2:06 UTC (permalink / raw)
  To: gdb-patches

We weren't using the enable_p flag to see whether the option should
be enabled or disabled, and we weren't breaking out when done parsing.
---
 sim/ppc/igen.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/sim/ppc/igen.c b/sim/ppc/igen.c
index 8aa19c757f59..9f642440541e 100644
--- a/sim/ppc/igen.c
+++ b/sim/ppc/igen.c
@@ -439,15 +439,22 @@ main(int argc,
               {
               case '=':
 	        icache_size = atoi (argp + strlen ("gen-icache") + 1);
-	        code |= generate_with_icache;
+		if (enable_p)
+		  code |= generate_with_icache;
+		else
+		  code &= ~generate_with_icache;
                 break;
               case '\0':
-	        code |= generate_with_icache;
+		if (enable_p)
+		  code |= generate_with_icache;
+		else
+		  code &= ~generate_with_icache;
                 break;
               default:
 		error ("Expecting -Ggen-icache or -Ggen-icache=<N>\n");
               }
           }
+	  break;
 	}
     case 'I':
       {
-- 
2.43.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-12-22  2:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-22  2:06 [PATCH/committed] sim: ppc: igen: fix -G handling Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).