From: Mark Wielaard <mark@klomp.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add keywords to TuiWindow.write
Date: Sun, 31 Dec 2023 20:57:31 +0100 [thread overview]
Message-ID: <20231231195731.GA2262@gnu.wildebeest.org> (raw)
In-Reply-To: <878r5bcx71.fsf@tromey.com>
Hi Tom,
On Sat, Dec 30, 2023 at 12:22:26PM -0700, Tom Tromey wrote:
> >>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> The gdb docs promise that methods with more than two or more arguments
> Tom> will accept keywords. However, I found that TuiWindow.write didn't
> Tom> allow them. This patch adds the missing support.
>
> I'm checking this in.
This broke the python black checker:
https://builder.sourceware.org/buildbot/#/builders/74/builds/6022
--- /home/builder/shared/bb1-2/worker/gdb-fedora-x86_64/binutils-gdb/gdb/testsuite/gdb.python/tui-window.py 2023-12-30 19:45:58.307468+00:00
+++ /home/builder/shared/bb1-2/worker/gdb-fedora-x86_64/binutils-gdb/gdb/testsuite/gdb.python/tui-window.py 2023-12-30 19:51:54.065041+00:00
@@ -30,12 +30,14 @@
def render(self):
self.win.erase()
w = self.win.width
h = self.win.height
- self.win.write(string="Test: " + str(self.count) + " " + str(w) + "x" + str(h),
- full_window=False)
+ self.win.write(
+ string="Test: " + str(self.count) + " " + str(w) + "x" + str(h),
+ full_window=False,
+ )
self.count = self.count + 1
# Tries to delete the title attribute. GDB will throw an error.
def remove_title(self):
del self.win.title
would reformat /home/builder/shared/bb1-2/worker/gdb-fedora-x86_64/binutils-gdb/gdb/testsuite/gdb.python/tui-window.py
Oh no! 💥 💔 💥
1 file would be reformatted, 149 files would be left unchanged.
prev parent reply other threads:[~2023-12-31 19:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 5:53 Tom Tromey
2023-12-30 19:22 ` Tom Tromey
2023-12-31 19:57 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231231195731.GA2262@gnu.wildebeest.org \
--to=mark@klomp.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).