From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH/submitted 04/10] sim: ppc: switch struct member checks to AC_CHECK_MEMBER
Date: Tue, 2 Jan 2024 00:36:32 -0500 [thread overview]
Message-ID: <20240102053639.28290-4-vapier@gentoo.org> (raw)
In-Reply-To: <20240102053639.28290-1-vapier@gentoo.org>
This covers a lot of the AC_MSG_CHECKING+AC_TRY_COMPILE+AC_MSG_RESULT
boilerplate and matches what we do in the top-level platform checks.
---
sim/ppc/configure | 127 +++++++++++++++++++++++++++----------------
sim/ppc/configure.ac | 40 +++++++-------
2 files changed, 99 insertions(+), 68 deletions(-)
diff --git a/sim/ppc/configure.ac b/sim/ppc/configure.ac
index e8354791a711..8810ff2f4726 100644
--- a/sim/ppc/configure.ac
+++ b/sim/ppc/configure.ac
@@ -306,19 +306,19 @@ if test $ac_cv_termios_struct = yes; then
fi
if test "$ac_cv_termios_struct" = "yes"; then
- AC_MSG_CHECKING(for c_line field in struct termios)
- AC_CACHE_VAL(ac_cv_termios_cline,
- [AC_TRY_COMPILE([#include <sys/types.h>
-#include <sys/termios.h>],
-[static struct termios x; x.c_line = 0;],
- ac_cv_termios_cline=yes, ac_cv_termios_cline=no)])
-
- AC_MSG_RESULT($ac_cv_termios_cline)
- if test $ac_cv_termios_cline = yes; then
+ AC_CACHE_VAL([sim_cv_termios_cline])
+ AC_CHECK_MEMBER(
+ [struct termios.c_line],
+ [sim_cv_termios_cline="yes"],
+ [sim_cv_termios_cline="no"], [
+#include <sys/types.h>
+#include <sys/termios.h>
+])
+ if test $sim_cv_termios_cline = yes; then
AC_DEFINE([HAVE_TERMIOS_CLINE], 1, [Define if struct termios has c_line.])
fi
else
- ac_cv_termios_cline=no
+ sim_cv_termios_cline=no
fi
if test "$ac_cv_termios_struct" != "yes"; then
@@ -342,19 +342,19 @@ else
fi
if test "$ac_cv_termio_struct" = "yes"; then
- AC_MSG_CHECKING(for c_line field in struct termio)
- AC_CACHE_VAL(ac_cv_termio_cline,
- [AC_TRY_COMPILE([#include <sys/types.h>
-#include <sys/termio.h>],
-[static struct termio x; x.c_line = 0;],
- ac_cv_termio_cline=yes, ac_cv_termio_cline=no)])
-
- AC_MSG_RESULT($ac_cv_termio_cline)
- if test $ac_cv_termio_cline = yes; then
+ AC_CACHE_VAL([sim_cv_termio_cline])
+ AC_CHECK_MEMBER(
+ [struct termio.c_line],
+ [sim_cv_termio_cline="yes"],
+ [sim_cv_termio_cline="no"], [
+#include <sys/types.h>
+#include <sys/termio.h>
+])
+ if test $sim_cv_termio_cline = yes; then
AC_DEFINE([HAVE_TERMIO_CLINE], 1, [Define if struct termio has c_line.])
fi
else
- ac_cv_termio_cline=no
+ sim_cv_termio_cline=no
fi
AC_SUBST(sim_line_nr)
--
2.43.0
next prev parent reply other threads:[~2024-01-02 6:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 5:36 [PATCH/submitted 01/10] sim: ppc: move long long test to top-level Mike Frysinger
2024-01-02 5:36 ` [PATCH/submitted 02/10] sim: ppc: move struct statfs " Mike Frysinger
2024-01-02 5:36 ` [PATCH/submitted 03/10] sim: ppc: move termio defines to config.h Mike Frysinger
2024-01-02 5:36 ` Mike Frysinger [this message]
2024-01-02 5:36 ` [PATCH/submitted 05/10] sim: ppc: switch to AC_CACHE_CHECK Mike Frysinger
2024-01-02 5:36 ` [PATCH/submitted 06/10] sim: ppc: move termios probes to top-level Mike Frysinger
2024-01-02 5:36 ` [PATCH/submitted 07/10] sim: ppc: stop including headers from gdb/ Mike Frysinger
2024-01-02 5:36 ` [PATCH/submitted 08/10] sim: ppc: drop custom config.h header Mike Frysinger
2024-01-02 5:36 ` [PATCH/submitted 09/10] sim: ppc: drop configure compiler checks Mike Frysinger
2024-01-02 5:36 ` [PATCH/submitted 10/10] sim: ppc: move defines.h generation to the top-level Mike Frysinger
2024-01-09 14:33 ` [PATCH/submitted 01/10] sim: ppc: move long long test to top-level Tom Tromey
2024-01-09 17:50 ` Mike Frysinger
2024-01-09 19:05 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240102053639.28290-4-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).