Re: [PATCH/submitted 01/10] sim: ppc: move long long test to top-level

[Tom Tromey <tom@tromey.com>]

>> FWIW gdb solves this problem with gdb/libiberty.m4.  Really this is
>> something that should be provided or fixed in a better way by libiberty.

Mike> in the mean time, seems like this file should get moved to gdbsupport/ since
Mike> gdb, gdbserver, and gdbsupport all rely on it ?  then it'd be more reasonable
Mike> for sim to include that directly.

It's fine by me.

Mike> thinking beyond that, config/acinclude.m4 has CYG_AC_PATH_LIBERTY, but no one
Mike> seems to be using that.  should we add config/libiberty.m4 and move all this
Mike> logic there ?  and prob have it take care of exporting a LIBIBERTY_LIB var ?

You'd probably want to open this discussion on gcc-patches.

I tend to think if bigger changes are being made here, then my
preferences would be:

1. Just avoid using any configure results in libiberty header files,
   perhaps by relying on more recent standard features.

2. Have libiberty namespace its configure results (i.e., rename them
   from the generic HAVE_* to LIBIBERTY_* or whatever) and provide /
   install a "libiberty-config.h".

3. What we have now, to me clearly the worst solution of the bunch.

Tom