public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/3] [gdb/symtab] Eliminate deferred_entry
Date: Thu,  4 Jan 2024 15:19:08 +0100	[thread overview]
Message-ID: <20240104141911.7596-1-tdevries@suse.de> (raw)

In a discussion of a proposed fix for PR symtab/30728 (
https://sourceware.org/pipermail/gdb-patches/2023-December/205068.html ), this
was mentioned:
...
I wonder then about just sticking this info directly into the
cooked_index_entry object, and then doing fixups directly on these in
the shard.

That is, instead of keeping separate "deferred" entries, just making
ordinary entries.  cooked_index_entry::parent_entry could be a union
holding either the parent (if known) or a CORE_ADDR; and then there
could be a new flag in cooked_index_flag_enum indicating which one is in
use.
...

This patch series implements that idea.

Tested on x86_64-linux.

Tom de Vries (3):
  [gdb/symtab] Allow changing of added cooked_index entries
  [gdb/symtab] Make cooked_index_entry::parent_entry private
  [gdb/symtab] Eliminate deferred_entry

 gdb/dwarf2/cooked-index.c | 21 ++++++-----
 gdb/dwarf2/cooked-index.h | 78 ++++++++++++++++++++++++++++++++-------
 gdb/dwarf2/read.c         | 51 +++++++++++--------------
 3 files changed, 99 insertions(+), 51 deletions(-)


base-commit: 2bcfdb758bb18e29cf6c0486c448bf78dbbc0c8a
-- 
2.35.3


             reply	other threads:[~2024-01-04 14:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04 14:19 Tom de Vries [this message]
2024-01-04 14:19 ` [PATCH 1/3] [gdb/symtab] Allow changing of added cooked_index entries Tom de Vries
2024-01-08 16:54   ` Alexandra Petlanova Hajkova
2024-01-04 14:19 ` [PATCH 2/3] [gdb/symtab] Make cooked_index_entry::parent_entry private Tom de Vries
2024-01-09 11:49   ` Alexandra Petlanova Hajkova
2024-01-04 14:19 ` [PATCH 3/3] [gdb/symtab] Eliminate deferred_entry Tom de Vries
2024-01-09 14:43 ` [PATCH 0/3] " Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240104141911.7596-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).