From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] [gdb/symtab] Eliminate deferred_entry
Date: Tue, 09 Jan 2024 07:43:11 -0700 [thread overview]
Message-ID: <875y02wosg.fsf@tromey.com> (raw)
In-Reply-To: <20240104141911.7596-1-tdevries@suse.de> (Tom de Vries's message of "Thu, 4 Jan 2024 15:19:08 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> In a discussion of a proposed fix for PR symtab/30728 (
Tom> https://sourceware.org/pipermail/gdb-patches/2023-December/205068.html ), this
Tom> was mentioned:
Tom> ...
Tom> I wonder then about just sticking this info directly into the
Tom> cooked_index_entry object, and then doing fixups directly on these in
Tom> the shard.
Tom> That is, instead of keeping separate "deferred" entries, just making
Tom> ordinary entries. cooked_index_entry::parent_entry could be a union
Tom> holding either the parent (if known) or a CORE_ADDR; and then there
Tom> could be a new flag in cooked_index_flag_enum indicating which one is in
Tom> use.
Tom> ...
Tom> This patch series implements that idea.
Thank you. This is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2024-01-09 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 14:19 Tom de Vries
2024-01-04 14:19 ` [PATCH 1/3] [gdb/symtab] Allow changing of added cooked_index entries Tom de Vries
2024-01-08 16:54 ` Alexandra Petlanova Hajkova
2024-01-04 14:19 ` [PATCH 2/3] [gdb/symtab] Make cooked_index_entry::parent_entry private Tom de Vries
2024-01-09 11:49 ` Alexandra Petlanova Hajkova
2024-01-04 14:19 ` [PATCH 3/3] [gdb/symtab] Eliminate deferred_entry Tom de Vries
2024-01-09 14:43 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y02wosg.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).