* [PATCH/committed] sim: igen: fix format-zero-length warnings
@ 2024-01-09 2:27 Mike Frysinger
0 siblings, 0 replies; only message in thread
From: Mike Frysinger @ 2024-01-09 2:27 UTC (permalink / raw)
To: gdb-patches
Fix warnings from calling printf functions with "" which normally
is useless.
---
sim/igen/gen.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/sim/igen/gen.c b/sim/igen/gen.c
index 2176b603fc59..30cf10770334 100644
--- a/sim/igen/gen.c
+++ b/sim/igen/gen.c
@@ -67,7 +67,11 @@ print_gen_entry_path (const line_ref *line,
if (table->top->model != NULL)
print (line, "%s", table->top->model->name);
else
- print (line, "");
+ {
+ /* We don't want to output things, but we want the side-effects they
+ might have (e.g. checking line != NULL). */
+ print (line, "%s", "");
+ }
}
else
{
@@ -1242,7 +1246,7 @@ gen_entry_expand_insns (gen_entry *table)
print_gen_entry_insns (table, warning,
"was not uniquely decoded",
"decodes to the same entry");
- error (NULL, "");
+ error (NULL, "unrecoverable\n");
}
return;
}
@@ -1385,7 +1389,7 @@ gen_entry_expand_insns (gen_entry *table)
warning (NULL,
": Applying rule just copied all instructions\n");
print_gen_entry_insns (entry, warning, "Copied", NULL);
- error (NULL, "");
+ error (NULL, "unrecoverable\n");
}
}
}
--
2.43.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-01-09 2:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-09 2:27 [PATCH/committed] sim: igen: fix format-zero-length warnings Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).