From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH] Fix handling of DW_OP_GNU_push_tls_address
Date: Wed, 17 Jan 2024 05:21:54 -0700 [thread overview]
Message-ID: <20240117122154.2880311-1-tromey@adacore.com> (raw)
In one spot, DW_OP_GNU_push_tls_address is handled differently from
DW_OP_form_tls_address. However, I think they should always be
treated identically.
---
gdb/dwarf2/loc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/dwarf2/loc.c b/gdb/dwarf2/loc.c
index 062bd12909f..6cc9cc62650 100644
--- a/gdb/dwarf2/loc.c
+++ b/gdb/dwarf2/loc.c
@@ -1955,12 +1955,12 @@ dwarf2_get_symbol_read_needs (gdb::array_view<const gdb_byte> expr,
case DW_OP_lt:
case DW_OP_gt:
case DW_OP_ne:
- case DW_OP_GNU_push_tls_address:
case DW_OP_nop:
case DW_OP_GNU_uninit:
case DW_OP_push_object_address:
break;
+ case DW_OP_GNU_push_tls_address:
case DW_OP_form_tls_address:
if (symbol_needs <= SYMBOL_NEEDS_REGISTERS)
symbol_needs = SYMBOL_NEEDS_REGISTERS;
--
2.43.0
next reply other threads:[~2024-01-17 12:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 12:21 Tom Tromey [this message]
2024-01-19 22:34 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240117122154.2880311-1-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).