* [PATCH] Fix handling of DW_OP_GNU_push_tls_address
@ 2024-01-17 12:21 Tom Tromey
2024-01-19 22:34 ` Kevin Buettner
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2024-01-17 12:21 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
In one spot, DW_OP_GNU_push_tls_address is handled differently from
DW_OP_form_tls_address. However, I think they should always be
treated identically.
---
gdb/dwarf2/loc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/dwarf2/loc.c b/gdb/dwarf2/loc.c
index 062bd12909f..6cc9cc62650 100644
--- a/gdb/dwarf2/loc.c
+++ b/gdb/dwarf2/loc.c
@@ -1955,12 +1955,12 @@ dwarf2_get_symbol_read_needs (gdb::array_view<const gdb_byte> expr,
case DW_OP_lt:
case DW_OP_gt:
case DW_OP_ne:
- case DW_OP_GNU_push_tls_address:
case DW_OP_nop:
case DW_OP_GNU_uninit:
case DW_OP_push_object_address:
break;
+ case DW_OP_GNU_push_tls_address:
case DW_OP_form_tls_address:
if (symbol_needs <= SYMBOL_NEEDS_REGISTERS)
symbol_needs = SYMBOL_NEEDS_REGISTERS;
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix handling of DW_OP_GNU_push_tls_address
2024-01-17 12:21 [PATCH] Fix handling of DW_OP_GNU_push_tls_address Tom Tromey
@ 2024-01-19 22:34 ` Kevin Buettner
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Buettner @ 2024-01-19 22:34 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On Wed, 17 Jan 2024 05:21:54 -0700
Tom Tromey <tromey@adacore.com> wrote:
> In one spot, DW_OP_GNU_push_tls_address is handled differently from
> DW_OP_form_tls_address. However, I think they should always be
> treated identically.
I agree.
Approved-by: Kevin Buettner <kevinb@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-19 22:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-17 12:21 [PATCH] Fix handling of DW_OP_GNU_push_tls_address Tom Tromey
2024-01-19 22:34 ` Kevin Buettner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).