From: Shahab Vahedi <list+gdb@vahedi.org>
To: gdb-patches@sourceware.org
Cc: Yuriy Kolerov <kolerov93@gmail.com>, Tom Tromey <tom@tromey.com>,
Shahab Vahedi <shahab@synopsys.com>
Subject: [PUSHED] arc: Don't use multiline in arc-disassembler-options.exp test
Date: Tue, 13 Feb 2024 22:55:15 +0100 [thread overview]
Message-ID: <20240213215515.27760-1-list+gdb@vahedi.org> (raw)
In-Reply-To: <20240213064022.32961-1-kolerov93@gmail.com>
From: Yuriy Kolerov <kolerov93@gmail.com>
Breaking a TCL string to several lines leads to adding of extra
symbols to the resulting expect string. In turn, this leads to
failing of all test cases in gdb.arch/arc-disassembler-options.exp
testsuite. It's necessary to use multi_line function in such
cases.
Approved-By: Tom Tromey <tom@tromey.com>
---
gdb/testsuite/gdb.arch/arc-disassembler-options.exp | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/gdb/testsuite/gdb.arch/arc-disassembler-options.exp b/gdb/testsuite/gdb.arch/arc-disassembler-options.exp
index 29c7e60b487..3a4c5234891 100644
--- a/gdb/testsuite/gdb.arch/arc-disassembler-options.exp
+++ b/gdb/testsuite/gdb.arch/arc-disassembler-options.exp
@@ -28,10 +28,11 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${objfile}" object {}] \
clean_restart ${objfile}
proc arc_disassemble_test { func insn mesg } {
- gdb_test "disassemble $func" \
- "Dump of assembler code for function $func:\r\n\
- \[^:\]+:\t$insn\r\nEnd of assembler dump\." \
- $mesg
+ set pass_re [multi_line \
+ "Dump of assembler code for function $func:" \
+ "\[^:\]+:\t$insn" \
+ "End of assembler dump\\."]
+ gdb_test "disassemble $func" $pass_re $mesg
}
# Verify defaults.
--
2.35.8
prev parent reply other threads:[~2024-02-13 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 6:40 [PATCH v4] " Yuriy Kolerov
2024-02-13 14:46 ` Tom Tromey
2024-02-13 21:55 ` Shahab Vahedi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213215515.27760-1-list+gdb@vahedi.org \
--to=list+gdb@vahedi.org \
--cc=gdb-patches@sourceware.org \
--cc=kolerov93@gmail.com \
--cc=shahab@synopsys.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).