From: Tom Tromey <tom@tromey.com>
To: Yuriy Kolerov <kolerov93@gmail.com>
Cc: gdb-patches@sourceware.org, shahab@synopsys.com
Subject: Re: [PATCH v4] arc: Don't use multiline in arc-disassembler-options.exp test
Date: Tue, 13 Feb 2024 07:46:46 -0700 [thread overview]
Message-ID: <8734tw776x.fsf@tromey.com> (raw)
In-Reply-To: <20240213064022.32961-1-kolerov93@gmail.com> (Yuriy Kolerov's message of "Tue, 13 Feb 2024 06:40:22 +0000")
>>>>> Yuriy Kolerov <kolerov93@gmail.com> writes:
> Breaking a TCL string to several lines leads to adding of extra
> symbols to the resulting expect string. In turn, this leads to
> failing of all test cases in gdb.arch/arc-disassembler-options.exp
> testsuite. It's necessary to use multi_line function in such
> cases.
> Signed-off-by: Yuriy Kolerov <kolerov93@gmail.com>
Thank you. This is ok.
Approved-By: Tom Tromey <tom@tromey.com>
If you don't have write access, and you plan to write more gdb patches,
please contact me off-list.
Tom
next prev parent reply other threads:[~2024-02-13 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 6:40 Yuriy Kolerov
2024-02-13 14:46 ` Tom Tromey [this message]
2024-02-13 21:55 ` [PUSHED] " Shahab Vahedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734tw776x.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=kolerov93@gmail.com \
--cc=shahab@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).