public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/7] Fix race in DWARF reader
Date: Sat, 17 Feb 2024 18:10:01 -0700	[thread overview]
Message-ID: <20240217-dwarf-race-relocate-v1-0-d3d2d908c1e8@tromey.com> (raw)

The background DWARF reader turns out to have a few races.  This
series fixes one that occurs when the indexer runs at the same time as
DWARF relocation.

Most of the series is just cleanup / preparation.

The main patch affects MIPS16.  I can't test this -- I tried on a MIPS
machine in the GCC compile farm, but unfortunately the relevant
gdb.arch test says that the processor doesn't support MIPS16.  It's
possible this code is simply dead; I do not know.

Regression tested on x86-64 Fedora 38.

---
Tom Tromey (7):
      Compare section index in lookup_minimal_symbol_by_pc_section
      Remove unnecessary null check in lookup_minimal_symbol_by_pc_section
      Hoist a call to frob_address
      Add unrelocated overload of lookup_minimal_symbol_by_pc_section
      Fix race in background DWARF indexer
      Use bound_minimal_symbol more in lookup_minimal_symbol_by_pc_section
      Fix address comparison in lookup_minimal_symbol_by_pc_section

 gdb/arch-utils.c          |   5 +-
 gdb/arch-utils.h          |   3 +-
 gdb/dwarf2/frame.c        |  13 +-
 gdb/dwarf2/read.c         |  12 +-
 gdb/gdbarch-gen.h         |   4 +-
 gdb/gdbarch.c             |   6 +-
 gdb/gdbarch_components.py |   4 +-
 gdb/minsyms.c             | 449 +++++++++++++++++++++++++---------------------
 gdb/minsyms.h             |   7 +
 gdb/mips-tdep.c           |  49 +++++
 gdb/mips-tdep.h           |   2 +
 11 files changed, 330 insertions(+), 224 deletions(-)
---
base-commit: 989aa9b8e8e340ba65f386cbfd239009a3aba68f
change-id: 20240217-dwarf-race-relocate-287780f3ac82

Best regards,
-- 
Tom Tromey <tom@tromey.com>


             reply	other threads:[~2024-02-18  1:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-18  1:10 Tom Tromey [this message]
2024-02-18  1:10 ` [PATCH 1/7] Compare section index in lookup_minimal_symbol_by_pc_section Tom Tromey
2024-02-18  1:10 ` [PATCH 2/7] Remove unnecessary null check " Tom Tromey
2024-02-18  1:10 ` [PATCH 3/7] Hoist a call to frob_address Tom Tromey
2024-02-18  1:10 ` [PATCH 4/7] Add unrelocated overload of lookup_minimal_symbol_by_pc_section Tom Tromey
2024-02-18  1:10 ` [PATCH 5/7] Fix race in background DWARF indexer Tom Tromey
2024-02-18  1:10 ` [PATCH 6/7] Use bound_minimal_symbol more in lookup_minimal_symbol_by_pc_section Tom Tromey
2024-02-18  1:10 ` [PATCH 7/7] Fix address comparison " Tom Tromey
2024-04-03 15:16 ` [PATCH 0/7] Fix race in DWARF reader Tom Tromey
2024-04-09 18:16   ` John Baldwin
2024-04-09 22:11     ` Luis Machado
2024-04-10  0:02       ` Maciej W. Rozycki
2024-04-16 17:05         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240217-dwarf-race-relocate-v1-0-d3d2d908c1e8@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).