From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/7] Remove unnecessary null check in lookup_minimal_symbol_by_pc_section
Date: Sat, 17 Feb 2024 18:10:03 -0700 [thread overview]
Message-ID: <20240217-dwarf-race-relocate-v1-2-d3d2d908c1e8@tromey.com> (raw)
In-Reply-To: <20240217-dwarf-race-relocate-v1-0-d3d2d908c1e8@tromey.com>
lookup_minimal_symbol_by_pc_section asserts that section != NULL early
in the function, rendering a later check (and comment) unnecessary.
---
gdb/minsyms.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/gdb/minsyms.c b/gdb/minsyms.c
index ffded3781c4..f63d0f4af61 100644
--- a/gdb/minsyms.c
+++ b/gdb/minsyms.c
@@ -876,13 +876,11 @@ lookup_minimal_symbol_by_pc_section (CORE_ADDR pc_in, struct obj_section *sectio
continue;
}
- /* If SECTION was specified, skip any symbol from
- wrong section. */
- if (section
- /* Some types of debug info, such as COFF,
+ /* Skip any symbol from wrong section. */
+ if (/* Some types of debug info, such as COFF,
don't fill the bfd_section member, so don't
throw away symbols on those platforms. */
- && msymbol[hi].obj_section (objfile) != nullptr
+ msymbol[hi].obj_section (objfile) != nullptr
&& (!matching_obj_sections
(msymbol[hi].obj_section (objfile),
section)))
--
2.43.0
next prev parent reply other threads:[~2024-02-18 1:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 1:10 [PATCH 0/7] Fix race in DWARF reader Tom Tromey
2024-02-18 1:10 ` [PATCH 1/7] Compare section index in lookup_minimal_symbol_by_pc_section Tom Tromey
2024-02-18 1:10 ` Tom Tromey [this message]
2024-02-18 1:10 ` [PATCH 3/7] Hoist a call to frob_address Tom Tromey
2024-02-18 1:10 ` [PATCH 4/7] Add unrelocated overload of lookup_minimal_symbol_by_pc_section Tom Tromey
2024-02-18 1:10 ` [PATCH 5/7] Fix race in background DWARF indexer Tom Tromey
2024-02-18 1:10 ` [PATCH 6/7] Use bound_minimal_symbol more in lookup_minimal_symbol_by_pc_section Tom Tromey
2024-02-18 1:10 ` [PATCH 7/7] Fix address comparison " Tom Tromey
2024-04-03 15:16 ` [PATCH 0/7] Fix race in DWARF reader Tom Tromey
2024-04-09 18:16 ` John Baldwin
2024-04-09 22:11 ` Luis Machado
2024-04-10 0:02 ` Maciej W. Rozycki
2024-04-16 17:05 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240217-dwarf-race-relocate-v1-2-d3d2d908c1e8@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).