public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH] [gdb/testsuite] Dump dap.log.$n to gdb.log when exceptions found
Date: Sat, 24 Feb 2024 10:48:55 +0100	[thread overview]
Message-ID: <20240224094855.14072-1-tdevries@suse.de> (raw)

For a patch I submitted, the Linaro CI reported a failure:
...
FAIL: gdb.dap/attach.exp: exceptions in log file
...

I ran the test-case locally, and observed the same FAIL in the gdb.sum file.

I then wanted to confirm that I reproduced the exact same problem, but
realized that I couldn't because there's no way for me to know what exception
occurred, and where, because that information is logged in the dap.log.$n
file, and the Linaro CI only saves the gdb.sum and gdb.log files.

This issue is even worse if only the CI can reproduce a FAIL.

Fix this in dap_check_log_file by dumping dap.log.$n to gdb.log when
exceptions are found.

Tested on x86_64-linux.
---
 gdb/testsuite/lib/dap-support.exp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gdb/testsuite/lib/dap-support.exp b/gdb/testsuite/lib/dap-support.exp
index 72c22d00711..89a4b0e0f6d 100644
--- a/gdb/testsuite/lib/dap-support.exp
+++ b/gdb/testsuite/lib/dap-support.exp
@@ -381,6 +381,9 @@ proc dap_check_log_file {} {
     if {$ok} {
 	pass "exceptions in log file"
     } else {
+	verbose -log --  "--- DAP LOG START ---"
+	verbose -log -- $contents
+	verbose -log --  "--- DAP LOG END ---"
 	fail "exceptions in log file"
     }
 }

base-commit: 086c8f406d82ce171d5867eed93f1308e07252c5
-- 
2.35.3


             reply	other threads:[~2024-02-24  9:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-24  9:48 Tom de Vries [this message]
2024-02-26 14:49 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240224094855.14072-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).