* [PATCH] [gdb/testsuite] Dump dap.log.$n to gdb.log when exceptions found
@ 2024-02-24 9:48 Tom de Vries
2024-02-26 14:49 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Tom de Vries @ 2024-02-24 9:48 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
For a patch I submitted, the Linaro CI reported a failure:
...
FAIL: gdb.dap/attach.exp: exceptions in log file
...
I ran the test-case locally, and observed the same FAIL in the gdb.sum file.
I then wanted to confirm that I reproduced the exact same problem, but
realized that I couldn't because there's no way for me to know what exception
occurred, and where, because that information is logged in the dap.log.$n
file, and the Linaro CI only saves the gdb.sum and gdb.log files.
This issue is even worse if only the CI can reproduce a FAIL.
Fix this in dap_check_log_file by dumping dap.log.$n to gdb.log when
exceptions are found.
Tested on x86_64-linux.
---
gdb/testsuite/lib/dap-support.exp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gdb/testsuite/lib/dap-support.exp b/gdb/testsuite/lib/dap-support.exp
index 72c22d00711..89a4b0e0f6d 100644
--- a/gdb/testsuite/lib/dap-support.exp
+++ b/gdb/testsuite/lib/dap-support.exp
@@ -381,6 +381,9 @@ proc dap_check_log_file {} {
if {$ok} {
pass "exceptions in log file"
} else {
+ verbose -log -- "--- DAP LOG START ---"
+ verbose -log -- $contents
+ verbose -log -- "--- DAP LOG END ---"
fail "exceptions in log file"
}
}
base-commit: 086c8f406d82ce171d5867eed93f1308e07252c5
--
2.35.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [gdb/testsuite] Dump dap.log.$n to gdb.log when exceptions found
2024-02-24 9:48 [PATCH] [gdb/testsuite] Dump dap.log.$n to gdb.log when exceptions found Tom de Vries
@ 2024-02-26 14:49 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2024-02-26 14:49 UTC (permalink / raw)
To: Tom de Vries; +Cc: gdb-patches, Tom Tromey
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Fix this in dap_check_log_file by dumping dap.log.$n to gdb.log when
Tom> exceptions are found.
Looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-26 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-24 9:48 [PATCH] [gdb/testsuite] Dump dap.log.$n to gdb.log when exceptions found Tom de Vries
2024-02-26 14:49 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).