From: <bhushan.attarde@imgtec.com>
To: <gdb-patches@sourceware.org>
Cc: <aburgess@redhat.com>, <vapier@gentoo.org>,
<Jaydeep.Patil@imgtec.com>,
Bhushan Attarde <bhushan.attarde@imgtec.com>
Subject: [PATCH 08/11] sim: riscv: Add double precision floating-point sign-injection, min and max instructions
Date: Mon, 26 Feb 2024 14:26:25 +0000 [thread overview]
Message-ID: <20240226142628.1629048-5-bhushan.attarde@imgtec.com> (raw)
In-Reply-To: <20240226142628.1629048-1-bhushan.attarde@imgtec.com>
From: Bhushan Attarde <bhushan.attarde@imgtec.com>
Added simulation of following single precision floating-point instructions
fsgnjn.d, fsgnjx.d, fmin.d and fmax.d.
Updated test file d-fp-compare.s and added d-fp-sign-inject.s in
sim/testsuite/riscv/ to test these instructions.
---
sim/riscv/sim-main.c | 65 +++++++++++++++++++
sim/testsuite/riscv/d-fp-compare.s | 22 +++++++
sim/testsuite/riscv/d-fp-sign-inject.s | 87 ++++++++++++++++++++++++++
3 files changed, 174 insertions(+)
create mode 100644 sim/testsuite/riscv/d-fp-sign-inject.s
diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c
index 4313516b8b7..4f347fbfc5e 100644
--- a/sim/riscv/sim-main.c
+++ b/sim/riscv/sim-main.c
@@ -1359,6 +1359,40 @@ float64_compare (SIM_CPU *cpu, int rd, int rs1, int rs2, int flags)
}
}
+/* Handle double precision floating point math instructions. */
+static void
+float64_math (SIM_CPU *cpu, int rd, int rs1, int rs2, int flags)
+{
+ struct riscv_sim_cpu *riscv_cpu = RISCV_SIM_CPU (cpu);
+ double a, b, result = 0;
+ uint64_t rs1_bits, rs2_bits, rd_bits;
+ const char *frd_name = riscv_fpr_names_abi[rd];
+ const char *frs1_name = riscv_fpr_names_abi[rs1];
+ const char *frs2_name = riscv_fpr_names_abi[rs2];
+
+ rs1_bits = (uint64_t) riscv_cpu->fpregs[rs1];
+ memcpy (&a, &rs1_bits, sizeof (a));
+ rs2_bits = (uint64_t) riscv_cpu->fpregs[rs2];
+ memcpy (&b, &rs2_bits, sizeof (b));
+
+ switch (flags)
+ {
+ case FMAX:
+ TRACE_INSN (cpu, "fmax.d %s, %s, %s;", frd_name, frs1_name, frs2_name);
+ result = fmax (a, b);
+ break;
+ case FMIN:
+ TRACE_INSN (cpu, "fmin.d %s, %s, %s;", frd_name, frs1_name, frs2_name);
+ result = fmin (a, b);
+ break;
+ }
+
+ /* Store result. */
+ memcpy (&rd_bits, &result, sizeof (result));
+ store_fp (cpu, rd, rd_bits);
+
+}
+
/* Simulate single precision floating point instructions. */
static sim_cia
execute_f (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op)
@@ -1668,6 +1702,37 @@ execute_d (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op)
store_fp (cpu, rd, rs1_bits);
break;
}
+ case MATCH_FSGNJN_D:
+ {
+ uint64_t rs1_bits, rs2_bits;
+ TRACE_INSN (cpu, "fsgnjn.d %s, %s, %s;", frd_name, frs1_name,
+ frs2_name);
+ rs1_bits = (uint64_t) riscv_cpu->fpregs[rs1];
+ rs2_bits = ~((uint64_t) riscv_cpu->fpregs[rs2]);
+ rs1_bits = (rs2_bits & 0x8000000000000000ull)
+ | (rs1_bits & 0x7fffffffffffffffull);
+ store_fp (cpu, rd, rs1_bits);
+ break;
+ }
+ case MATCH_FSGNJX_D:
+ {
+ uint64_t rs1_bits, rs2_bits;
+ TRACE_INSN (cpu, "fsgnjx.d %s, %s, %s;", frd_name, frs1_name,
+ frs2_name);
+ rs1_bits = (uint64_t) riscv_cpu->fpregs[rs1];
+ rs2_bits = (uint64_t) riscv_cpu->fpregs[rs2];
+ rs1_bits = ((rs1_bits & 0x8000000000000000ull)
+ ^ (rs2_bits & 0x8000000000000000ull))
+ | (rs1_bits & 0x7fffffffffffffffull);
+ store_fp (cpu, rd, rs1_bits);
+ break;
+ }
+ case MATCH_FMIN_D:
+ float64_math (cpu, rd, rs1, rs2, FMIN);
+ break;
+ case MATCH_FMAX_D:
+ float64_math (cpu, rd, rs1, rs2, FMAX);
+ break;
default:
TRACE_INSN (cpu, "UNHANDLED INSN: %s", op->name);
sim_engine_halt (sd, cpu, NULL, riscv_cpu->pc, sim_signalled, SIM_SIGILL);
diff --git a/sim/testsuite/riscv/d-fp-compare.s b/sim/testsuite/riscv/d-fp-compare.s
index 0e168fed9de..1a926211216 100755
--- a/sim/testsuite/riscv/d-fp-compare.s
+++ b/sim/testsuite/riscv/d-fp-compare.s
@@ -20,11 +20,16 @@ _arg2:
.double 0.5
.double 2.2
+_expected:
+ .double 0.5
+ .double 2.2
+
start
.option push
.option norelax
la a0,_arg1
la a1,_arg2
+ la a2,_expected
li a3,1
.option pop
@@ -65,6 +70,23 @@ _arg2:
fclass.d a4,fa0
bne a3,a4,test_fail
+ # Test fmin.d instruction.
+ fld fa0,0(a0)
+ fld fa1,8(a1)
+ fld fa2,0(a2)
+ fmin.d fa3,fa0,fa1
+ feq.d a4,fa3,fa2
+ li a3,1
+ bne a4,a3,test_fail
+
+ # Test fmax.d instruction.
+ fld fa0,0(a0)
+ fld fa1,8(a1)
+ fld fa2,8(a2)
+ fmax.d fa3,fa0,fa1
+ feq.d a4,fa3,fa2
+ bne a4,a3,test_fail
+
test_pass:
pass
diff --git a/sim/testsuite/riscv/d-fp-sign-inject.s b/sim/testsuite/riscv/d-fp-sign-inject.s
new file mode 100644
index 00000000000..c2f61ba3cdd
--- /dev/null
+++ b/sim/testsuite/riscv/d-fp-sign-inject.s
@@ -0,0 +1,87 @@
+# Double precision sign-injection instructions.
+# mach: riscv64
+# sim(riscv64): --model RV64ID
+# ld(riscv64): -m elf64lriscv
+# as(riscv64): -march=rv64id
+
+.include "testutils.inc"
+
+ .section .data
+ .align 3
+
+_arg1:
+ .double 2.0
+ .double -2.0
+
+_arg2:
+ .double 1.0
+ .double -1.0
+
+_expected:
+ .double 2.0
+ .double -2.0
+
+ start
+ .option push
+ .option norelax
+ la a0,_arg1
+ la a1,_arg2
+ la a2,_expected
+ li a3,1
+ .option pop
+
+ # Test fsgnj.d instruction.
+ fld fa0,0(a0)
+ fld fa1,0(a1)
+ fld fa2,0(a2)
+ fsgnj.d fa3,fa0,fa1
+ feq.d a4,fa3,fa2
+ bne a4,a3,test_fail
+ fld fa1,8(a1)
+ fld fa2,8(a2)
+ fsgnj.d fa3,fa0,fa1
+ feq.d a4,fa3,fa2
+ bne a4,a3,test_fail
+
+ # Test fsgnjn.d (fneg.d) instruction.
+ fld fa0,0(a0)
+ fld fa1,0(a1)
+ fld fa2,8(a2)
+ fsgnjn.d fa3,fa0,fa1
+ feq.d a4,fa3,fa2
+ bne a4,a3,test_fail
+ fld fa1,8(a1)
+ fld fa2,0(a2)
+ fsgnjn.d fa3,fa0,fa1
+ feq.d a4,fa3,fa2
+ bne a4,a3,test_fail
+ fld fa0,0(a0)
+ fld fa2,8(a2)
+ fneg.d fa3,fa0
+ feq.d a4,fa3,fa2
+ bne a4,a3,test_fail
+
+ # Test fsgnjx.d (fabs.d) instruction.
+ fld fa0,0(a0)
+ fld fa1,8(a1)
+ fld fa2,8(a2)
+ fsgnjx.d fa3,fa0,fa1
+ feq.d a4,fa3,fa2
+ bne a4,a3,test_fail
+ fld fa0,8(a0)
+ fld fa1,8(a1)
+ fld fa2,0(a2)
+ fsgnjx.d fa3,fa0,fa1
+ feq.d a4,fa3,fa2
+ bne a4,a3,test_fail
+ fld fa0,8(a0)
+ fld fa2,0(a2)
+ fabs.d fa3,fa0
+ feq.d a4,fa3,fa2
+ bne a4,a3,test_fail
+
+test_pass:
+ pass
+
+test_fail:
+ fail
--
2.25.1
prev parent reply other threads:[~2024-02-26 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 14:26 [PATCH 04/11] sim: riscv: Add single precision floating-point MAC instructions bhushan.attarde
2024-02-26 14:26 ` [PATCH 05/11] sim: riscv: Add single precision floating-point basic arithmetic instructions bhushan.attarde
2024-02-26 14:26 ` [PATCH 06/11] sim: riscv: Add single-precision floating-point conversion instructions bhushan.attarde
2024-02-26 14:26 ` [PATCH 07/11] sim: riscv: Add double precision floating-point load-store, move, compare and classify instructions bhushan.attarde
2024-02-26 14:26 ` bhushan.attarde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226142628.1629048-5-bhushan.attarde@imgtec.com \
--to=bhushan.attarde@imgtec.com \
--cc=Jaydeep.Patil@imgtec.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).