From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom de Vries <tdevries@suse.de>
Subject: [PATCH v4 4/4] Use the .py file in gdb.dap/pause.exp
Date: Tue, 27 Feb 2024 07:45:52 -0700 [thread overview]
Message-ID: <20240227-py-simple-exc-v4-4-3341d342c126@adacore.com> (raw)
In-Reply-To: <20240227-py-simple-exc-v4-0-3341d342c126@adacore.com>
Tom de Vries pointed out that the gdb.dap/pause.exp test writes a
Python file but then does not use it. This patch corrects the
oversight.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31354
Reviewed-By: Tom de Vries <tdevries@suse.de>
---
gdb/testsuite/gdb.dap/pause.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.dap/pause.exp b/gdb/testsuite/gdb.dap/pause.exp
index 4d13dadd3ad..9038d0f037f 100644
--- a/gdb/testsuite/gdb.dap/pause.exp
+++ b/gdb/testsuite/gdb.dap/pause.exp
@@ -134,7 +134,7 @@ dap_read_response cancel $cancel_id
# does not continue the inferior) can be canceled.
#
-write_file py "while True:\n pass"
+set gdbfile [write_file py "while True:\n pass"]
set cont_id [dap_send_request evaluate \
[format {o expression [s "source %s"] context [s repl]} \
$gdbfile]]
--
2.43.0
next prev parent reply other threads:[~2024-02-27 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 14:45 [PATCH v4 0/4] Fix DAP pause bug Tom Tromey
2024-02-27 14:45 ` [PATCH v4 1/4] Introduce read_remainder_of_file Tom Tromey
2024-02-27 14:45 ` [PATCH v4 2/4] Fix formatting buglet in python.c Tom Tromey
2024-02-27 14:45 ` [PATCH v4 3/4] Rewrite "python" command exception handling Tom Tromey
2024-02-27 16:03 ` Tom de Vries
2024-02-27 16:04 ` Eli Zaretskii
2024-03-07 10:00 ` Lancelot SIX
2024-03-08 16:19 ` Tom Tromey
2024-03-08 19:24 ` Tom Tromey
2024-02-27 14:45 ` Tom Tromey [this message]
2024-02-27 16:56 ` [PATCH v4 0/4] Fix DAP pause bug Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227-py-simple-exc-v4-4-3341d342c126@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).