Re: [PATCH v4 3/4] Rewrite "python" command exception handling

[Eli Zaretskii <eliz@gnu.org>]

> From: Tom Tromey <tromey@adacore.com>
> Date: Tue, 27 Feb 2024 07:45:51 -0700
> 
> The "python" command (and the Python implementation of the gdb
> "source" command) does not handle Python exceptions in the same way as
> other gdb-facing Python code.  In particular, exceptions are turned
> into a generic error rather than being routed through
> gdbpy_handle_exception, which takes care of converting to 'quit' as
> appropriate.
> 
> I think this was done this way because PyRun_SimpleFile and friends do
> not propagate the Python exception -- they simply indicate that one
> occurred.
> 
> This patch reimplements these functions to respect the general gdb
> convention here.  As a bonus, some Windows-specific code can be
> removed, as can the _execute_file function.
> 
> The bulk of this change is tweaking the test suite to match the new
> way that exceptions are displayed.  These changes are largely
> uninteresting.  However, it's worth pointing out the py-error.exp
> change.  Here, the failure changes because the test changes the host
> charset to something that isn't supported by Python.  This then
> results in a weird error in the new setup.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31354
> ---
>  gdb/doc/python.texi                               |   6 +-
>  gdb/python/lib/gdb/__init__.py                    |  27 ------
>  gdb/python/python.c                               | 109 +++++++++-------------
>  gdb/testsuite/gdb.ada/tasks.exp                   |   8 +-
>  gdb/testsuite/gdb.python/py-arch.exp              |   2 +-
>  gdb/testsuite/gdb.python/py-block.exp             |   4 +-
>  gdb/testsuite/gdb.python/py-breakpoint.exp        |  18 ++--
>  gdb/testsuite/gdb.python/py-connection.exp        |   8 +-
>  gdb/testsuite/gdb.python/py-disasm.exp            |  32 +++----
>  gdb/testsuite/gdb.python/py-error.exp             |   9 +-
>  gdb/testsuite/gdb.python/py-finish-breakpoint.exp |   2 +-
>  gdb/testsuite/gdb.python/py-format-address.exp    |  28 +++---
>  gdb/testsuite/gdb.python/py-format-string.exp     |   8 +-
>  gdb/testsuite/gdb.python/py-frame.exp             |  18 ++--
>  gdb/testsuite/gdb.python/py-inferior.exp          |  24 ++---
>  gdb/testsuite/gdb.python/py-lazy-string.exp       |   6 +-
>  gdb/testsuite/gdb.python/py-mi-cmd.exp            |  40 ++++----
>  gdb/testsuite/gdb.python/py-missing-debug.exp     |  16 ++--
>  gdb/testsuite/gdb.python/py-objfile.exp           |   2 +-
>  gdb/testsuite/gdb.python/py-parameter.exp         |  14 +--
>  gdb/testsuite/gdb.python/py-pp-registration.exp   |   2 +-
>  gdb/testsuite/gdb.python/py-progspace-events.exp  |   2 +-
>  gdb/testsuite/gdb.python/py-progspace.exp         |   8 +-
>  gdb/testsuite/gdb.python/py-record-btrace.exp     |   4 +-
>  gdb/testsuite/gdb.python/py-record-full.exp       |   4 +-
>  gdb/testsuite/gdb.python/py-template.exp          |   2 +-
>  gdb/testsuite/gdb.python/py-thrhandle.exp         |   2 +-
>  gdb/testsuite/gdb.python/py-type.exp              |  20 ++--
>  gdb/testsuite/gdb.python/py-unwind.exp            |  24 ++---
>  gdb/testsuite/gdb.python/py-value.exp             |  36 +++----
>  gdb/testsuite/gdb.python/python.exp               |  10 +-
>  gdb/testsuite/gdb.python/tui-window-names.exp     |  16 ++--
>  gdb/testsuite/gdb.python/tui-window.exp           |   2 +-
>  gdb/testsuite/lib/gdb-python.exp                  |   2 +-
>  34 files changed, 237 insertions(+), 278 deletions(-)

Thanks, the documentation part is okay.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>