public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] arc: Don't build arc-analyze-prologue.S with -g
@ 2024-02-22  8:02 Yuriy Kolerov
  2024-02-27 14:03 ` Shahab Vahedi
  2024-02-27 14:12 ` [PUSHED] " Shahab Vahedi
  0 siblings, 2 replies; 3+ messages in thread
From: Yuriy Kolerov @ 2024-02-22  8:02 UTC (permalink / raw)
  To: gdb-patches, shahab; +Cc: Yuriy Kolerov

arc-analyze-prologue.S test does not contain debug information thus
it must be compiled without -g option. Otherwise GDB will try to
unwind frames using debug information (which does not exist for .S
code!) instead of analyzing frames manually.

Signed-off-by: Yuriy Kolerov <kolerov93@gmail.com>
---
 gdb/testsuite/gdb.arch/arc-analyze-prologue.exp | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp
index f414d9ccde0..371858ec0bc 100644
--- a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp
+++ b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp
@@ -19,7 +19,13 @@ require {istarget "arc*-*-*"}
 
 standard_testfile .S
 
-if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
+# arc-analyze-prologue.S test does not contain debug information thus it must
+# be compiled without -g option. Otherwise GDB will try to unwind frames using
+# debug information (which does not exist for .S code!) instead of analyzing
+# frames manually.
+set options {}
+
+if { [prepare_for_testing "failed to prepare" $testfile $srcfile $options] } {
     return -1
 }
 
-- 
2.39.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arc: Don't build arc-analyze-prologue.S with -g
  2024-02-22  8:02 [PATCH] arc: Don't build arc-analyze-prologue.S with -g Yuriy Kolerov
@ 2024-02-27 14:03 ` Shahab Vahedi
  2024-02-27 14:12 ` [PUSHED] " Shahab Vahedi
  1 sibling, 0 replies; 3+ messages in thread
From: Shahab Vahedi @ 2024-02-27 14:03 UTC (permalink / raw)
  To: Yuriy Kolerov; +Cc: gdb-patches, Shahab Vahedi

On 2/22/24 09:02, Yuriy Kolerov wrote:
> arc-analyze-prologue.S test does not contain debug information thus
> it must be compiled without -g option. Otherwise GDB will try to
> unwind frames using debug information (which does not exist for .S
> code!) instead of analyzing frames manually.
> 
> Signed-off-by: Yuriy Kolerov <kolerov93@gmail.com>
> ---
>  gdb/testsuite/gdb.arch/arc-analyze-prologue.exp | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Approved-By: Shahab Vahedi <shahab@synopsys.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PUSHED] arc: Don't build arc-analyze-prologue.S with -g
  2024-02-22  8:02 [PATCH] arc: Don't build arc-analyze-prologue.S with -g Yuriy Kolerov
  2024-02-27 14:03 ` Shahab Vahedi
@ 2024-02-27 14:12 ` Shahab Vahedi
  1 sibling, 0 replies; 3+ messages in thread
From: Shahab Vahedi @ 2024-02-27 14:12 UTC (permalink / raw)
  To: gdb-patches; +Cc: Yuriy Kolerov, Shahab Vahedi

From: Yuriy Kolerov <kolerov93@gmail.com>

arc-analyze-prologue.S test does not contain debug information thus
it must be compiled without -g option. Otherwise GDB will try to
unwind frames using debug information (which does not exist for .S
code!) instead of analyzing frames manually.

Approved-By: Shahab Vahedi <shahab@synopsys.com>
---
 gdb/testsuite/gdb.arch/arc-analyze-prologue.exp | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp
index 32387c00169..b8d9a8fb75f 100644
--- a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp
+++ b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp
@@ -19,7 +19,13 @@ require {istarget "arc*-*-*"}
 
 standard_testfile .S
 
-if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
+# arc-analyze-prologue.S test does not contain debug information thus it must
+# be compiled without -g option. Otherwise GDB will try to unwind frames using
+# debug information (which does not exist for .S code!) instead of analyzing
+# frames manually.
+set options {}
+
+if { [prepare_for_testing "failed to prepare" $testfile $srcfile $options] } {
     return -1
 }
 
-- 
2.35.8


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-02-27 14:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-22  8:02 [PATCH] arc: Don't build arc-analyze-prologue.S with -g Yuriy Kolerov
2024-02-27 14:03 ` Shahab Vahedi
2024-02-27 14:12 ` [PUSHED] " Shahab Vahedi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).