From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH] gdb/Makefile.in: remove ACLOCAL_AMFLAGS
Date: Mon, 11 Mar 2024 15:32:40 -0400 [thread overview]
Message-ID: <20240311193243.335656-1-simon.marchi@efficios.com> (raw)
aclocal picks up the relevant include paths from AC_CONFIG_MACRO_DIRS in
configure.ac, so there's no need to pass `-I ../config` here.
Passing `-I ../config` is actually annoying, because it makes the output
different between when the update is triggered by the maintainer mode
and when aclocal or autoreconf is ran with no special flags. The
difference in the output is due to the order of include paths being
different.
Change-Id: I2c963876516570842f20b4a6a470867e7a941006
---
gdb/Makefile.in | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 0e0f19c40c9f..e83fbc5d146a 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -2317,7 +2317,6 @@ config.status: $(srcdir)/configure configure.nat configure.tgt configure.host ..
$(SHELL) config.status --recheck
ACLOCAL = aclocal
-ACLOCAL_AMFLAGS = -I ../config
# Keep these in sync with the includes in acinclude.m4.
aclocal_m4_deps = \
@@ -2345,7 +2344,7 @@ aclocal_m4_deps = \
../config/ax_pthread.m4
$(srcdir)/aclocal.m4: @MAINTAINER_MODE_TRUE@ $(aclocal_m4_deps)
- cd $(srcdir) && $(ACLOCAL) $(ACLOCAL_AMFLAGS)
+ cd $(srcdir) && $(ACLOCAL)
AUTOCONF = autoconf
configure_deps = $(srcdir)/configure.ac $(srcdir)/aclocal.m4
base-commit: 1320cb92da10d194a5bb0c34ce552dffa52faeb5
--
2.44.0
next reply other threads:[~2024-03-11 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 19:32 Simon Marchi [this message]
2024-03-11 20:19 ` Tom Tromey
2024-03-11 21:02 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311193243.335656-1-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).