public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@efficios.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/Makefile.in: remove ACLOCAL_AMFLAGS
Date: Mon, 11 Mar 2024 17:02:46 -0400	[thread overview]
Message-ID: <72607538-91b2-4108-94b3-95172d33caf1@efficios.com> (raw)
In-Reply-To: <87v85so72d.fsf@tromey.com>

On 3/11/24 16:19, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> aclocal picks up the relevant include paths from AC_CONFIG_MACRO_DIRS in
> Simon> configure.ac, so there's no need to pass `-I ../config` here.
> 
> Simon> Passing `-I ../config` is actually annoying, because it makes the output
> Simon> different between when the update is triggered by the maintainer mode
> Simon> and when aclocal or autoreconf is ran with no special flags.  The
> Simon> difference in the output is due to the order of include paths being
> Simon> different.
> 
> Thanks.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thanks, pushed.

Simon

      reply	other threads:[~2024-03-11 21:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 19:32 Simon Marchi
2024-03-11 20:19 ` Tom Tromey
2024-03-11 21:02   ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72607538-91b2-4108-94b3-95172d33caf1@efficios.com \
    --to=simon.marchi@efficios.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).