public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] [gdb/testsuite] Fix gdb.base/list-no-debug.exp on debian
@ 2024-03-17  9:29 Tom de Vries
  2024-03-17 14:14 ` Andrew Burgess
  0 siblings, 1 reply; 2+ messages in thread
From: Tom de Vries @ 2024-03-17  9:29 UTC (permalink / raw)
  To: gdb-patches

From: linux <linux@mxqpro.fritz.box>

On debian 12, aarch64-linux I run into:
...
(gdb) list .^M
No symbol table is loaded.  Use the "file" command.^M
(gdb) FAIL: gdb.base/list-nodebug.exp: first 'list .'
...

The test-case expects some debug info, but none for main.  Instead, there's no
debug info at all.

Fix this by adding another source file to the test-case, and compiling it with
debug info.

Tested on aarch64-linux.

PR testsuite/31290
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31290
---
 gdb/testsuite/gdb.base/list-nodebug-2.c | 24 ++++++++++++++++++++++++
 gdb/testsuite/gdb.base/list-nodebug.c   |  7 +++++--
 gdb/testsuite/gdb.base/list-nodebug.exp | 10 +++++++---
 3 files changed, 36 insertions(+), 5 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/list-nodebug-2.c

diff --git a/gdb/testsuite/gdb.base/list-nodebug-2.c b/gdb/testsuite/gdb.base/list-nodebug-2.c
new file mode 100644
index 00000000000..861e6149071
--- /dev/null
+++ b/gdb/testsuite/gdb.base/list-nodebug-2.c
@@ -0,0 +1,24 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2024 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+extern int foo (void);
+
+int
+foo (void)
+{
+  return 0;
+}
diff --git a/gdb/testsuite/gdb.base/list-nodebug.c b/gdb/testsuite/gdb.base/list-nodebug.c
index 078517c011e..d4ae6787310 100644
--- a/gdb/testsuite/gdb.base/list-nodebug.c
+++ b/gdb/testsuite/gdb.base/list-nodebug.c
@@ -15,7 +15,10 @@
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
-int main ()
+extern int foo (void);
+
+int
+main (void)
 {
-    return 0;
+  return foo ();
 }
diff --git a/gdb/testsuite/gdb.base/list-nodebug.exp b/gdb/testsuite/gdb.base/list-nodebug.exp
index 08de05423af..274e7de0391 100644
--- a/gdb/testsuite/gdb.base/list-nodebug.exp
+++ b/gdb/testsuite/gdb.base/list-nodebug.exp
@@ -16,13 +16,17 @@
 # Test that using the command "list" in a file with no debug information
 # will not crash GDB and will give reasonable output.
 
-standard_testfile .c
+standard_testfile .c -2.c
 
-if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
-    {nodebug}]} {
+if {[build_executable_from_specs "failed to prepare" \
+	 $testfile {} \
+	 $srcfile {nodebug} \
+	 $srcfile2 {debug}]} {
     return -1
 }
 
+clean_restart $testfile
+
 if {![runto_main]} {
     untested "couldn't run to main"
     return

base-commit: 04d7f8a5bc3a2b4be65583b10ef100bc567faca1
-- 
2.35.3


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-17 14:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-17  9:29 [PATCH] [gdb/testsuite] Fix gdb.base/list-no-debug.exp on debian Tom de Vries
2024-03-17 14:14 ` Andrew Burgess

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).