From: Markus Metzger <markus.t.metzger@intel.com>
To: gdb-patches@sourceware.org
Cc: pedro@palves.net, Guinevere Larsen <blarsen@redhat.com>
Subject: [PATCH v5 3/4] gdb, infrun, record: move no-history notification into normal_stop
Date: Wed, 10 Apr 2024 07:46:12 +0000 [thread overview]
Message-ID: <20240410074613.54520-4-markus.t.metzger@intel.com> (raw)
In-Reply-To: <20240410074613.54520-1-markus.t.metzger@intel.com>
Leave calling gdb::observers::no_history.notify to normal_stop based on
the last waitstatus.
Reviewed-By: Guinevere Larsen <blarsen@redhat.com>
---
gdb/infrun.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gdb/infrun.c b/gdb/infrun.c
index cda9afc3dfb..d3738ebbd66 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -6573,8 +6573,6 @@ handle_inferior_event (struct execution_control_state *ecs)
if (handle_stop_requested (ecs))
return;
- interps_notify_no_history ();
-
/* Cancel an in-flight step-over. It will not succeed since we
won't be able to step at the end of the execution history. */
{
@@ -9037,7 +9035,6 @@ keep_going_pass_signal (struct execution_control_state *ecs)
if (ecs->event_thread->control.is_replaying
&& !target_record_is_replaying (ecs->event_thread->ptid))
{
- interps_notify_no_history ();
ecs->ws.set_no_history ();
set_last_target_status (ecs->target, ecs->ptid, ecs->ws);
stop_print_frame = true;
@@ -9677,6 +9674,9 @@ normal_stop ()
if (saved_context.changed ())
return true;
+ if (last.kind () == TARGET_WAITKIND_NO_HISTORY)
+ interps_notify_no_history ();
+
/* Notify observers about the stop. This is where the interpreters
print the stop event. */
notify_normal_stop ((inferior_ptid != null_ptid
--
2.34.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2024-04-10 7:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 7:46 [PATCH v5 0/4] PR gdb/31353 Markus Metzger
2024-04-10 7:46 ` [PATCH v5 1/4] gdb, infrun, btrace: fix reverse/replay stepping at end of execution history Markus Metzger
2024-04-10 7:46 ` [PATCH v5 2/4] gdb, infrun, record: fix hang when step-over fails with no-history Markus Metzger
2024-04-10 7:46 ` Markus Metzger [this message]
2024-04-10 7:46 ` [PATCH v5 4/4] gdb, infrun: fix multi-threaded reverse stepping Markus Metzger
2024-04-12 19:50 ` Guinevere Larsen
2024-04-15 9:03 ` Metzger, Markus T
2024-04-15 12:44 ` Guinevere Larsen
2024-05-03 5:26 ` [PING] [PATCH v5 0/4] PR gdb/31353 Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410074613.54520-4-markus.t.metzger@intel.com \
--to=markus.t.metzger@intel.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).