From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Guinevere Larsen <blarsen@redhat.com>
Cc: "pedro@palves.net" <pedro@palves.net>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v5 4/4] gdb, infrun: fix multi-threaded reverse stepping
Date: Mon, 15 Apr 2024 09:03:12 +0000 [thread overview]
Message-ID: <DM8PR11MB57499424AF3D8658EE19CF06DE092@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)
In-Reply-To: <049130fa-da68-4834-8655-7e5a1c43de00@redhat.com>
>> @@ -179,6 +186,9 @@ struct thread_control_state
>>
>> /* Whether the thread was replaying when the command was issued. */
>> bool is_replaying = false;
>> +
>> + /* The execution direction when the command was issued. */
>> + enum exec_direction_kind execution_direction = EXEC_FORWARD;
>
>I'm a bit unsure of this... Mostly wondering if this makes sense to be a
>thread-specific information. Does it make sense for one thread to have a
>direction being forward and another backwards? I would think this is not
>a good idea (if not impossible).
You can have one thread going forward and the other going backward.
Both are replaying; we do not allow recording one thread while another
thread in the same inferior is replaying.
Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2024-04-15 9:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 7:46 [PATCH v5 0/4] PR gdb/31353 Markus Metzger
2024-04-10 7:46 ` [PATCH v5 1/4] gdb, infrun, btrace: fix reverse/replay stepping at end of execution history Markus Metzger
2024-04-10 7:46 ` [PATCH v5 2/4] gdb, infrun, record: fix hang when step-over fails with no-history Markus Metzger
2024-04-10 7:46 ` [PATCH v5 3/4] gdb, infrun, record: move no-history notification into normal_stop Markus Metzger
2024-04-10 7:46 ` [PATCH v5 4/4] gdb, infrun: fix multi-threaded reverse stepping Markus Metzger
2024-04-12 19:50 ` Guinevere Larsen
2024-04-15 9:03 ` Metzger, Markus T [this message]
2024-04-15 12:44 ` Guinevere Larsen
2024-05-03 5:26 ` [PING] [PATCH v5 0/4] PR gdb/31353 Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB57499424AF3D8658EE19CF06DE092@DM8PR11MB5749.namprd11.prod.outlook.com \
--to=markus.t.metzger@intel.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).