From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/2] gdb/testsuite: Add libc_has_debug_info require helper
Date: Sat, 20 Apr 2024 18:33:06 -0300 [thread overview]
Message-ID: <20240420213307.976401-2-thiago.bauermann@linaro.org> (raw)
In-Reply-To: <20240420213307.976401-1-thiago.bauermann@linaro.org>
Factor the test for libc debug info out of gdb.base/relativedebug.exp to
a new procedure.
Also, change the "info sharedlibrary" test to explicitly detect when
libc has debug info.
---
gdb/testsuite/gdb.base/relativedebug.exp | 13 +-----
gdb/testsuite/lib/gdb.exp | 54 ++++++++++++++++++++++++
2 files changed, 55 insertions(+), 12 deletions(-)
diff --git a/gdb/testsuite/gdb.base/relativedebug.exp b/gdb/testsuite/gdb.base/relativedebug.exp
index bf8d76887122..f882a5cf1676 100644
--- a/gdb/testsuite/gdb.base/relativedebug.exp
+++ b/gdb/testsuite/gdb.base/relativedebug.exp
@@ -13,7 +13,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-require {!target_info exists gdb,nosignals}
+require {!target_info exists gdb,nosignals} libc_has_debug_info
standard_testfile .c
@@ -28,17 +28,6 @@ clean_restart ${binfile}
runto_main
-set test "info sharedlibrary"
-gdb_test_multiple $test $test {
- -re ".*\(\\*\)\[^\r\n\]*/libc\.so.*$gdb_prompt $" {
- # Skip the test below if libc doesn't have debug info.
- unsupported "libc doesn't have debug info"
- return -1
- }
- -re ".*$gdb_prompt $" {
- }
-}
-
# pause () -> SIGALRM -> handler () -> abort ()
gdb_test "continue" "Program received signal SIGABRT.*"
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index ddee928d5104..9af73bef8f09 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3699,6 +3699,60 @@ proc support_displaced_stepping {} {
return 0
}
+# Return 1 if GDB can find the libc debug info, or 0 and a reason string if it
+# can't. This procedure is meant to be called by the require procedure.
+gdb_caching_proc libc_has_debug_info {} {
+ global srcdir subdir gdb_prompt inferior_exited_re
+
+ set me "libc_has_debug_info"
+
+ # Compile a test program.
+ set src {
+ int main (void) {
+ printf ("Hello, world!\n");
+ return 0;
+ }
+ }
+ if {![gdb_simple_compile $me $src executable {debug}]} {
+ return [list 0 "failed to compile test program"]
+ }
+
+ # No error message, compilation succeeded so now run it via gdb.
+
+ gdb_exit
+ gdb_start
+ gdb_reinitialize_dir $srcdir/$subdir
+ gdb_load "$obj"
+ runto_main
+ set test "info sharedlibrary libc.so"
+ gdb_test_multiple $test $test {
+ -re ".*\(\\*\)\[^\r\n\]*/libc\.so.*$gdb_prompt $" {
+ # Matched the "(*)" in the "Syms Read" columns which means:
+ # "(*): Shared library is missing debugging information."
+ verbose -log "$me: libc doesn't have debug info"
+ set libc_has_debug_info 0
+ set message "libc doesn't have debug info"
+ }
+ -re ".*Yes\[ \t\]+\[^\r\n\]*/libc\.so.*$gdb_prompt $" {
+ verbose -log "$me: libc has debug info"
+ set libc_has_debug_info 1
+ }
+ default {
+ set libc_has_debug_info 0
+ set message "libc not found in the inferior"
+ }
+ }
+ gdb_exit
+ remote_file build delete $obj
+
+ verbose "$me: returning $libc_has_debug_info" 2
+ if { $libc_has_debug_info } {
+ return $libc_has_debug_info
+ } else {
+ return [list $libc_has_debug_info $message]
+ }
+}
+
# Run a test on the target to see if it supports vmx hardware. Return 1 if so,
# 0 if it does not. Based on 'check_vmx_hw_available' from the GCC testsuite.
next prev parent reply other threads:[~2024-04-20 21:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 21:33 [PATCH 0/2] Add testcase for libc memory operations Thiago Jung Bauermann
2024-04-20 21:33 ` Thiago Jung Bauermann [this message]
2024-04-21 20:44 ` [PATCH 1/2] gdb/testsuite: Add libc_has_debug_info require helper Kevin Buettner
2024-04-21 21:02 ` Kevin Buettner
2024-04-22 0:05 ` Thiago Jung Bauermann
2024-04-20 21:33 ` [PATCH 2/2] gdb/testsuite: Add gdb.base/memops-watchpoint.exp Thiago Jung Bauermann
2024-04-21 21:20 ` Kevin Buettner
2024-04-22 0:24 ` Thiago Jung Bauermann
2024-04-22 18:40 ` Kevin Buettner
2024-04-23 1:20 ` Thiago Jung Bauermann
2024-04-22 23:04 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240420213307.976401-2-thiago.bauermann@linaro.org \
--to=thiago.bauermann@linaro.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).