Re: [PATCH 1/2] gdb/testsuite: Add libc_has_debug_info require helper

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Hello Kevin,

Thank you for your review! Sorry for sending v2 without addressing your
comments. I only saw your emails after I sent the series.

Kevin Buettner <kevinb@redhat.com> writes:

> On Sun, 21 Apr 2024 13:44:06 -0700
> Kevin Buettner <kevinb@redhat.com> wrote:
>
>> On Sat, 20 Apr 2024 18:33:06 -0300
>> Thiago Jung Bauermann <thiago.bauermann@linaro.org> wrote:
>>
>> > Factor the test for libc debug info out of gdb.base/relativedebug.exp to
>> > a new procedure.
>> >
>> > Also, change the "info sharedlibrary" test to explicitly detect when
>> > libc has debug info.
>>
>> LGTM.
>>
>> Approved-by: Kevin Buettner <kevinb@redhat.com>
>
> Just found a problem...  While attempting to test part 2 using clang:
>
> make check RUNTESTFLAGS="CC_FOR_TARGET=clang" TESTS="gdb.base/memops-watchpoint.exp"
>
> Then, in the log file:
>
> get_compiler_info: clang-17-0-6
> Executing on host: clang  /mesquite2/sourceware-git/f39-review/bld/gdb/testsuite/temp/164548/libc_has_debug_info.c   -fdiagnostics-color=never -Wno-unknown-warning-option -w -g -g  -lm  -o /mesquite2/sourceware-git/f39-review/bld/gdb/testsuite/temp/164548/libc_has_debug_info.x    (timeout = 300)
> builtin_spawn -ignore SIGHUP clang /mesquite2/sourceware-git/f39-review/bld/gdb/testsuite/temp/164548/libc_has_debug_info.c -fdiagnostics-color=never -Wno-unknown-warning-option -w -g -g -lm -o /mesquite2/sourceware-git/f39-review/bld/gdb/testsuite/temp/164548/libc_has_debug_info.x
> /mesquite2/sourceware-git/f39-review/bld/gdb/testsuite/temp/164548/libc_has_debug_info.c:3:6: error: call to undeclared library function 'printf' with type 'int (const char *, ...)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>     3 |             printf ("Hello, world!\n");
>       |             ^
> /mesquite2/sourceware-git/f39-review/bld/gdb/testsuite/temp/164548/libc_has_debug_info.c:3:6: note: include the header <stdio.h> or explicitly provide a declaration for 'printf'
> 1 error generated.
> compiler exited with status 1
> UNSUPPORTED: gdb.base/memops-watchpoint.exp: require failed: libc_has_debug_info (failed to compile test program)
>
> My testing shows that things will work if you add the suggested #include to
> the "set src" text.

Ah, of course. GCC doesn't complain about it because of the -w option:

       -w  Inhibit all warning messages.

and in GCC this is a warning not an error.

I'll fix it in the next version.

--
Thiago