From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Use scoped_restore in varobj.c
Date: Mon, 24 Apr 2023 15:35:01 -0400 [thread overview]
Message-ID: <202a30ec-1579-9919-9051-ff88c6824560@simark.ca> (raw)
In-Reply-To: <20230424182711.726180-1-tromey@adacore.com>
On 4/24/23 14:27, Tom Tromey via Gdb-patches wrote:
> One spot in varobj.c should use scoped_restore to save and restore
> input_radix. Note that the current code may fail to restore it on
> error, so this patch fixes a latent bug.
Thanks, LGTM.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
prev parent reply other threads:[~2023-04-24 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 18:27 Tom Tromey
2023-04-24 19:35 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202a30ec-1579-9919-9051-ff88c6824560@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).