Re: [PATCH 3/3] [gdb] Fix assertion failure for checkpoint delete 0

[Tom de Vries <tdevries@suse.de>]

On 1/10/24 06:28, Kevin Buettner wrote:
> On Mon,  8 Jan 2024 16:25:53 +0100
> Tom de Vries <tdevries@suse.de> wrote:
> 
>> When doing "checkpoint delete 0" we run into an assertion failure:
>> ...
>> +delete checkpoint 0
>> inferior.c:406: internal-error: find_inferior_pid: Assertion `pid != 0' failed.
>> ...
>>
>> Fix this by handling the "pptid == null_ptid" case in
>> delete_checkpoint_command.
>>
>> Tested on x86_64-linux.
>>
>> PR gdb/31209
>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id
> 
> The Bug URL above is missing an '=31209' at the end.
> 
> Otherwise, LGTM.
> 
> Approved-By: Kevin Buettner <kevinb@redhat.com>

Thanks for the reviews.

The linaro CI found:
...
(gdb) PASS: gdb.base/checkpoint-ns.exp: delete checkpoint 0: checkpoint
restart 1
Switching to Thread 0xfffff7ff7e60 (LWP 146669)
#0  main () at 
/home/tcwg-build/workspace/tcwg_gnu_0/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.base/checkpoint.c:28
28	  char *tmp = &linebuf[0];
(gdb) FAIL: gdb.base/checkpoint-ns.exp: delete checkpoint 0: restart 1
...
so I'll commit shortly with this minor update:
...
-    gdb_test "restart 1" "Switching to process $decimal\r\n.*"
+    gdb_test "restart 1" "Switching to .*"
...

Thanks,
- Tom