From: Tom de Vries <tdevries@suse.de>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCHv3 0/3] gdb/python: avoid throwing an exception over libopcodes code
Date: Mon, 28 Nov 2022 09:35:24 +0100 [thread overview]
Message-ID: <22ccd823-9331-c693-a3e6-1ba5e4eb3e34@suse.de> (raw)
In-Reply-To: <cover.1668790576.git.aburgess@redhat.com>
On 11/18/22 17:57, Andrew Burgess via Gdb-patches wrote:
> Changes since v2:
>
> - Rebase onto current upstream/master, no merged conflicts.
>
> Changes since v1:
>
> - Patch #1 is largely unchanged. I'm still in discussion with Simon
> as to whether this is the correct solution or not.
>
> - Patch #2 has grown a little since the first version I posted, I
> found a few extra callbacks which can be marked as noexcept.
>
> - Patch #3 is new, this adds the noexcept keyword to the typedefs
> used to handle the libopcode callbacks, but only when we compile
> for C++17 or later.
>
> ---
>
> Andrew Burgess (3):
> gdb/python: avoid throwing an exception over libopcodes code
> gdb/disasm: mark functions passed to the disassembler noexcept
> gdb: mark disassembler function callback types as noexcept
>
Hi,
I ran into the same problem on powerpc64le, applied the patch series and
rebuild gdb, reran the test-case gdb.python/py-disasm.exp and it passes now.
Thanks,
- Tom
> gdb/disasm-selftests.c | 5 ++-
> gdb/disasm.c | 25 ++++++------
> gdb/disasm.h | 48 ++++++++++++++++------
> gdb/guile/scm-disasm.c | 2 +-
> gdb/python/py-disasm.c | 91 ++++++++++++++++++++++++++++++++----------
> 5 files changed, 121 insertions(+), 50 deletions(-)
>
>
> base-commit: f9f88aede3bb84efd088a59a5f6bccb3a6bb6516
prev parent reply other threads:[~2022-11-28 8:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 12:50 [PATCH] " Andrew Burgess
2022-10-24 15:50 ` Simon Marchi
2022-10-24 17:22 ` Andrew Burgess
2022-10-24 17:45 ` [PATCH] gdb/disasm: mark functions passed to the disassembler noexcept Andrew Burgess
2022-10-24 18:24 ` Simon Marchi
2022-10-24 18:20 ` [PATCH] gdb/python: avoid throwing an exception over libopcodes code Simon Marchi
2022-10-27 10:38 ` Andrew Burgess
2022-10-27 15:38 ` [PATCHv2 0/3] " Andrew Burgess
2022-10-27 15:38 ` [PATCHv2 1/3] " Andrew Burgess
2022-11-28 14:39 ` Simon Marchi
2022-11-28 19:26 ` Andrew Burgess
2022-10-27 15:38 ` [PATCHv2 2/3] gdb/disasm: mark functions passed to the disassembler noexcept Andrew Burgess
2022-10-27 15:38 ` [PATCHv2 3/3] gdb: mark disassembler function callback types as noexcept Andrew Burgess
2022-11-18 16:57 ` [PATCHv3 0/3] gdb/python: avoid throwing an exception over libopcodes code Andrew Burgess
2022-11-18 16:57 ` [PATCHv3 1/3] " Andrew Burgess
2022-11-18 16:57 ` [PATCHv3 2/3] gdb/disasm: mark functions passed to the disassembler noexcept Andrew Burgess
2022-11-18 16:57 ` [PATCHv3 3/3] gdb: mark disassembler function callback types as noexcept Andrew Burgess
2022-11-28 8:35 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22ccd823-9331-c693-a3e6-1ba5e4eb3e34@suse.de \
--to=tdevries@suse.de \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).