RE: [PATCH 2/2 ver 3] PowerPC, fix support for printing the function return value for non-trivial values.

[Carl Love <cel@us.ibm.com>]

On Wed, 2022-11-16 at 10:20 +0000, Lancelot SIX wrote:
> Hi Carl,
> 
<snip>
> > s RETURN_VALUE_STRUCT_CONVENTION,
> >       attempt to determine the address of the return buffer.  */
> > -  enum return_value_convention return_value;
> > -  struct gdbarch *gdbarch = get_frame_arch (callee_frame);
> > +  if (sm->function != NULL)
> 
> I know that Ulrich has already approved the patch, but to follow the
> coding standard the NULL should be replaced by nullptr.  If this is
> not
> too much trouble and is OK with maintainers, I think it would be nice
> to
> do this minor tweak.
> 
> > +    {
> > +      enum return_value_convention return_value;
> > +      struct gdbarch *gdbarch = get_frame_arch (callee_frame);
> >  
> > -  struct type * val_type
> > -    = check_typedef (sm->function->type ()->target_type ());
> > +      struct type * val_type
> > +	= check_typedef (sm->function->type ()->target_type ());
> >  
> > -  return_value = gdbarch_return_value (gdbarch,
> > -				       read_var_value (sm->function,
> > NULL,
> > -						       callee_frame),
> > -				       val_type, NULL, NULL, NULL);
> > +      return_value = gdbarch_return_value (gdbarch,
> > +					   read_var_value (sm-
> > >function, NULL,
> > +							   callee_frame
> > ),
> > +					   val_type, NULL, NULL, NULL);
> 
> While at it, those NULL could probably be updated I guess.

I think at this point it is probably best to do a new clean up patch
particularly since the other NULLs are not part of the fix patch.

I will go ahead and commit the fix and then put together a clean up
patch to address all the NULLs.   Thanks for letting me know about it.

                   Carl Love