From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove call to registers_changed from windows-nat.c
Date: Thu, 1 Dec 2022 13:34:46 -0500 [thread overview]
Message-ID: <2715d293-122f-10ff-e631-38b9c9a70562@simark.ca> (raw)
In-Reply-To: <20221201182857.2591740-1-tromey@adacore.com>
On 12/1/22 13:28, Tom Tromey via Gdb-patches wrote:
> I noticed that windows_nat_target::interrupt calls registers_changed.
> However, I don't think there's any reason to do this, because this
> will happen automatically when the inferior stop is processed.
> ---
> gdb/windows-nat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
> index 17422e15f80..4b0760c5804 100644
> --- a/gdb/windows-nat.c
> +++ b/gdb/windows-nat.c
> @@ -2881,7 +2881,6 @@ windows_nat_target::interrupt ()
> DEBUG_EVENTS ("GenerateConsoleCtrlEvent (CTRLC_EVENT, 0)");
> CHECK (GenerateConsoleCtrlEvent (CTRL_C_EVENT,
> windows_process.current_event.dwProcessId));
> - registers_changed (); /* refresh register state */
> }
>
> /* Helper for windows_xfer_partial that handles memory transfers.
> --
> 2.34.3
>
Makes sense to me,
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
prev parent reply other threads:[~2022-12-01 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 18:28 Tom Tromey
2022-12-01 18:34 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2715d293-122f-10ff-e631-38b9c9a70562@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).