public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Bruno Larsen <blarsen@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 2/2] gdb/reverse: Fix stepping over recursive functions
Date: Fri, 30 Sep 2022 19:28:17 +0100	[thread overview]
Message-ID: <2b2701f2-3624-75ca-6af5-02abb6126804@palves.net> (raw)
In-Reply-To: <20220831120727.2742360-3-blarsen@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 9596 bytes --]

On 2022-08-31 1:07 p.m., Bruno Larsen wrote:
> Currently, when using GDB to do reverse debugging, if we try to use the
> command "reverse next" to skip a recursive function, instead of skipping
> all of the recursive calls and stopping in the previous line, we stop at
> the second to last recursive call, and need to manually step backwards
> until we leave the first call.  This is well documented in PR gdb/16678.
> 
> This bug happens because when GDB notices that a reverse step has
> entered into a function, GDB will add a step_resume_breakpoint at the
> start of the function, then single step out of the prologue once that
> breakpoint is hit.  The problem was happening because GDB wouldn't give
> that step_resume_breakpoint a frame-id, so the first time the breakpoint
> was hit, the inferior would be stopped.  This is fixed by giving the
> current frame-id to the breakpoint.
> 
> This commit also changes gdb.reverse/step-reverse.c to contain a
> recursive function and attempt to both, skip it altogether, and to skip
> the second call from inside the first call, as this setup broke a
> previous version of the patch.
> ---
>  gdb/infrun.c                                |  2 +-
>  gdb/testsuite/gdb.reverse/step-precsave.exp |  6 ++-
>  gdb/testsuite/gdb.reverse/step-reverse.c    | 18 ++++++-
>  gdb/testsuite/gdb.reverse/step-reverse.exp  | 58 +++++++++++++++++++--
>  4 files changed, 76 insertions(+), 8 deletions(-)
> 
> diff --git a/gdb/infrun.c b/gdb/infrun.c
> index 033699bc3f7..679a0c83ece 100644
> --- a/gdb/infrun.c
> +++ b/gdb/infrun.c
> @@ -7133,7 +7133,7 @@ process_event_stop_test (struct execution_control_state *ecs)
>  		  sr_sal.pc = ecs->stop_func_start;
>  		  sr_sal.pspace = get_frame_program_space (frame);
>  		  insert_step_resume_breakpoint_at_sal (gdbarch,
> -							sr_sal, null_frame_id);
> +							sr_sal, get_stack_frame_id (frame));
>  		}
>  	    }
>  	  else
> diff --git a/gdb/testsuite/gdb.reverse/step-precsave.exp b/gdb/testsuite/gdb.reverse/step-precsave.exp
> index 0836ed2629f..3279b6ce879 100644
> --- a/gdb/testsuite/gdb.reverse/step-precsave.exp
> +++ b/gdb/testsuite/gdb.reverse/step-precsave.exp
> @@ -86,7 +86,8 @@ gdb_test "step 3" ".*STEP TEST 2.*" "step test 2"
>  
>  # step over call
>  
> -gdb_test "step" ".*NEXT OVER THIS CALL.*" "step up to call"
> +gdb_test "step" ".*NEXT OVER THIS RECURSION.*" "step up to call"
> +gdb_test "next" ".*NEXT OVER THIS CALL.*" "skip recursive call"
>  gdb_test "next" ".*STEP INTO THIS CALL.*" "next over call"
>  
>  # step into call
> @@ -280,9 +281,10 @@ gdb_test_multiple "step" "$test_message" {
>      }
>  }
>  
> -# next backward over call
> +# Next backward over calls.
>  
>  gdb_test "next" ".*NEXT OVER THIS CALL.*" "reverse next over call"
> +gdb_test "next" ".*NEXT OVER THIS RECURSION.*" "reverse next over recursive call"
>  
>  # step/next backward with count
>  
> diff --git a/gdb/testsuite/gdb.reverse/step-reverse.c b/gdb/testsuite/gdb.reverse/step-reverse.c
> index aea2a98541d..3d647b9b29d 100644
> --- a/gdb/testsuite/gdb.reverse/step-reverse.c
> +++ b/gdb/testsuite/gdb.reverse/step-reverse.c
> @@ -26,6 +26,19 @@ int callee() {		/* ENTER CALLEE */
>    return myglob++;	/* ARRIVED IN CALLEE */
>  }			/* RETURN FROM CALLEE */
>  
> +/* We need to make this function take more than a single instruction
> +   to run, otherwise it could hide PR gdb/16678, as reverse execution can
> +   step over a single-instruction function.  */
> +int
> +recursive_callee (int val)
> +{
> +    if (val == 0) return 0;
> +    val /= 2;
> +    if (val > 1)
> +	val++;
> +    return recursive_callee (val);	/* RECURSIVE CALL */
> +} /* EXIT RECURSIVE FUNCTION */

Could you make the function follow GNU formatting?  I know that the file
has other bits that don't follow the style, but we can just not add more cases.

> +
>  /* A structure which, we hope, will need to be passed using memcpy.  */
>  struct rhomboidal {
>    int rather_large[100];
> @@ -51,6 +64,9 @@ int main () {
>     y = y + 4;
>     z = z + 5;	/* STEP TEST 2 */
>  
> +   /* Test that next goes over recursive calls too */
> +   recursive_callee (32); /* NEXT OVER THIS RECURSION */
> +
>     /* Test that "next" goes over a call */
>     callee();	/* NEXT OVER THIS CALL */
>  
> @@ -60,7 +76,7 @@ int main () {
>     /* Test "stepi" */
>     a[5] = a[3] - a[4]; /* FINISH TEST */
>     callee();	/* STEPI TEST */
> -   
> +
>     /* Test "nexti" */
>     callee();	/* NEXTI TEST */
>  
> diff --git a/gdb/testsuite/gdb.reverse/step-reverse.exp b/gdb/testsuite/gdb.reverse/step-reverse.exp
> index 997b62604d5..a540b1f88ce 100644
> --- a/gdb/testsuite/gdb.reverse/step-reverse.exp
> +++ b/gdb/testsuite/gdb.reverse/step-reverse.exp
> @@ -47,9 +47,11 @@ gdb_test "step" ".*STEP TEST 1.*" "step test 1"
>  gdb_test "next 2" ".*NEXT TEST 2.*" "next test 2"
>  gdb_test "step 3" ".*STEP TEST 2.*" "step test 2"
>  
> +# Next through a recursive function call.
> +gdb_test "next 2" "NEXT OVER THIS CALL.*" "next over recursion"
> +
>  # step over call
>  
> -gdb_test "step" ".*NEXT OVER THIS CALL.*" "step up to call"
>  gdb_test "next" ".*STEP INTO THIS CALL.*" "next over call"
>  
>  # step into call
> @@ -118,7 +120,7 @@ gdb_test_multiple "stepi" "$test_message" {
>  
>  set test_message "stepi back from function call"
>  gdb_test_multiple "stepi" "$test_message" {
> -    -re "NEXTI TEST.*$gdb_prompt $" {
> +    -re -wrap "NEXTI TEST.*" {
>  	pass "$test_message"
>      }
>      -re "ARRIVED IN CALLEE.*$gdb_prompt $" {
> @@ -143,7 +145,6 @@ gdb_test_multiple "stepi" "$test_message" {
>  ###
>  
>  # Set reverse execution direction
> -
>  gdb_test_no_output "set exec-dir reverse" "set reverse execution"
>  
>  # stepi backward thru return and into a function
> @@ -243,10 +244,59 @@ gdb_test_multiple "step" "$test_message" {
>      }
>  }
>  
> -# next backward over call
> +# Next backward over call.
>  
>  gdb_test "next" ".*NEXT OVER THIS CALL.*" "reverse next over call"
>  
> +set step_out 0
> +gdb_test_multiple "next" "reverse next over recursion" {
> +    -re -wrap ".*NEXT OVER THIS RECURSION.*" {
> +	pass "$gdb_test_name"
> +    }
> +    -re -wrap ".*RECURSIVE CALL.*" {
> +	fail "$gdb_test_name"
> +	set step_out 1
> +    }
> +}
> +if { "$step_out" == 1 } {
> +    gdb_test_multiple "next" "stepping out of recursion" {
> +	-re -wrap "NEXT OVER THIS RECURSION.*" {
> +	    set step_out 0
> +	}
> +	-re -wrap ".*" {
> +	    send_gdb "reverse-next\n"
> +	    exp_continue

The command passed to gdb_test_multiple was "next", but here you
do "reverse-next".  Seems best to be consistent.  After, this can
potentially infinite loop of the reverse-next never takes you to the
expected line, which seems a bit dangerous.

> +	}
> +    }
> +}
> +
> +# Step forward over recursion again so we can test stepping over calls
> +# inside the recursion itself.
> +gdb_test_no_output "set exec-dir forward" "forward again to test recursion"
> +gdb_test "next" "NEXT OVER THIS CALL.*" "reverse next over recursion again"
> +gdb_test_no_output "set exec-dir reverse" "reverse again to test recursion"
> +
> +gdb_test "step" ".*EXIT RECURSIVE FUNCTION.*" "enter recursive function"
> +set step_pass 1
> +gdb_test_multiple "next" "step over recursion inside the recursion" {
> +    -re -wrap ".*EXIT RECURSIVE FUNCTION.*" {
> +	set step_pass 0
> +	send_gdb "next\n"
> +	exp_continue
> +    }
> +    -re -wrap ".*NEXT OVER THIS RECURSION.*" {
> +	if {$step_pass} {
> +	    pass "step over recursion inside the recursion"
> +	} else {
> +	    fail "step over recursion inside the recursion"
> +	}

gdb_assert

> +    }
> +    -re -wrap ".*" {
> +	send_gdb "next\n"

Ditto, re. infinite loop.

> +	exp_continue
> +    }
> +}
> +

Other than that, it looks fine to me.  

I still see this failing on Ubuntu 20.04, though.  I haven't investigated why.  I've attached
the gdb.log, in case something jumps out as obvious to you.

The before/after gdb.sum diff shows that some other tests FAIL on this machine, so maybe
it's just more of the same.

@@ -13,7 +13,7 @@ PASS: gdb.reverse/step-reverse.exp: next
 PASS: gdb.reverse/step-reverse.exp: step test 1
 PASS: gdb.reverse/step-reverse.exp: next test 2
 PASS: gdb.reverse/step-reverse.exp: step test 2
-PASS: gdb.reverse/step-reverse.exp: step up to call 
+PASS: gdb.reverse/step-reverse.exp: next over recursion 
 PASS: gdb.reverse/step-reverse.exp: next over call
 PASS: gdb.reverse/step-reverse.exp: step into call
 PASS: gdb.reverse/step-reverse.exp: finish out of fn call
@@ -27,14 +27,20 @@ PASS: gdb.reverse/step-reverse.exp: simp
 FAIL: gdb.reverse/step-reverse.exp: reverse step into fn call
 FAIL: gdb.reverse/step-reverse.exp: reverse step out of called fn
 FAIL: gdb.reverse/step-reverse.exp: reverse next over call
-FAIL: gdb.reverse/step-reverse.exp: reverse step test 1 
-FAIL: gdb.reverse/step-reverse.exp: reverse next test 1 
-FAIL: gdb.reverse/step-reverse.exp: reverse step test 2 
-FAIL: gdb.reverse/step-reverse.exp: reverse next test 2 
+FAIL: gdb.reverse/step-reverse.exp: reverse next over recursion 
+PASS: gdb.reverse/step-reverse.exp: forward again to test recursion 
+FAIL: gdb.reverse/step-reverse.exp: reverse next over recursion again 
+PASS: gdb.reverse/step-reverse.exp: reverse again to test recursion 
+FAIL: gdb.reverse/step-reverse.exp: enter recursive function 
+PASS: gdb.reverse/step-reverse.exp: step over recursion inside the recursion 
+PASS: gdb.reverse/step-reverse.exp: reverse step test 1 
+PASS: gdb.reverse/step-reverse.exp: reverse next test 1 
+PASS: gdb.reverse/step-reverse.exp: reverse step test 2 


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gdb.log --]
[-- Type: text/x-log; name="gdb.log", Size: 11016 bytes --]

Test run by pedro on Fri Sep 30 17:52:30 2022
Native configuration is x86_64-pc-linux-gnu

		=== gdb tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/config/unix.exp as tool-and-target-specific interface file.
Running /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.exp ...
Executing on host: gcc   -fdiagnostics-color=never -c -o /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/temp/1465468/ccopts1465468.o /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/temp/1465468/ccopts1465468.c    (timeout = 300)
builtin_spawn -ignore SIGHUP gcc -fdiagnostics-color=never -c -o /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/temp/1465468/ccopts1465468.o /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/temp/1465468/ccopts1465468.c
get_compiler_info: gcc-9-4-0
Executing on host: gcc  -fno-stack-protector  -fdiagnostics-color=never -c -g  -o /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.reverse/step-reverse/step-reverse0.o /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c    (timeout = 300)
builtin_spawn -ignore SIGHUP gcc -fno-stack-protector -fdiagnostics-color=never -c -g -o /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.reverse/step-reverse/step-reverse0.o /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c
Executing on host: gcc  -fno-stack-protector /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.reverse/step-reverse/step-reverse0.o  -fdiagnostics-color=never -g  -lm   -o /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.reverse/step-reverse/step-reverse    (timeout = 300)
builtin_spawn -ignore SIGHUP gcc -fno-stack-protector /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.reverse/step-reverse/step-reverse0.o -fdiagnostics-color=never -g -lm -o /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.reverse/step-reverse/step-reverse
builtin_spawn /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/../../gdb/gdb -nw -nx -iex set height 0 -iex set width 0 -data-directory /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/../data-directory
GNU gdb (GDB) 13.0.50.20220930-git
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word".
(gdb) set height 0
(gdb) set width 0
(gdb) dir
Reinitialize source path to empty? (y or n) y
Source directories searched: $cdir:$cwd
(gdb) dir /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse
Source directories searched: /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse:$cdir:$cwd
(gdb) kill
The program is not being run.
(gdb) file /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.reverse/step-reverse/step-reverse
Reading symbols from /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.reverse/step-reverse/step-reverse...
(gdb) delete breakpoints
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) break -qualified main
Breakpoint 1 at 0x11f1: file /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c, line 58.
(gdb) run 
Starting program: /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.reverse/step-reverse/step-reverse 

Breakpoint 1, main () at /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c:58
58	   w = 0;	/* BREAK AT MAIN */
(gdb) record
(gdb) PASS: gdb.reverse/step-reverse.exp: turn on process record
next
59	   x = 1;	/* NEXT TEST 1 */
(gdb) PASS: gdb.reverse/step-reverse.exp: next test 1
step
60	   y = 2;	/* STEP TEST 1 */
(gdb) PASS: gdb.reverse/step-reverse.exp: step test 1
next 2
62	   w = w + 2;	/* NEXT TEST 2 */
(gdb) PASS: gdb.reverse/step-reverse.exp: next test 2
step 3
65	   z = z + 5;	/* STEP TEST 2 */
(gdb) PASS: gdb.reverse/step-reverse.exp: step test 2
next 2
71	   callee();	/* NEXT OVER THIS CALL */
(gdb) PASS: gdb.reverse/step-reverse.exp: next over recursion
next
74	   callee();	/* STEP INTO THIS CALL */
(gdb) PASS: gdb.reverse/step-reverse.exp: next over call
step
callee () at /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c:26
26	  return myglob++;	/* ARRIVED IN CALLEE */
(gdb) PASS: gdb.reverse/step-reverse.exp: step into call
finish
Run till exit from #0  callee () at /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c:26
main () at /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c:77
77	   a[5] = a[3] - a[4]; /* FINISH TEST */
Value returned is $1 = 1
(gdb) PASS: gdb.reverse/step-reverse.exp: finish out of fn call
stepi
77	   a[5] = a[3] - a[4]; /* FINISH TEST */
(gdb) stepi
77	   a[5] = a[3] - a[4]; /* FINISH TEST */
(gdb) stepi
0x0000555555555243	77	   a[5] = a[3] - a[4]; /* FINISH TEST */
(gdb) stepi
77	   a[5] = a[3] - a[4]; /* FINISH TEST */
(gdb) stepi
78	   callee();	/* STEPI TEST */
(gdb) PASS: gdb.reverse/step-reverse.exp: simple stepi
stepi
0x000055555555524d	78	   callee();	/* STEPI TEST */
(gdb) stepi
callee () at /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c:25
25	int callee() {		/* ENTER CALLEE */
(gdb) stepi
0x000055555555516d	25	int callee() {		/* ENTER CALLEE */
(gdb) stepi
0x000055555555516e	25	int callee() {		/* ENTER CALLEE */
(gdb) stepi
26	  return myglob++;	/* ARRIVED IN CALLEE */
(gdb) PASS: gdb.reverse/step-reverse.exp: stepi into function call
stepi
0x0000555555555177	26	  return myglob++;	/* ARRIVED IN CALLEE */
(gdb) stepi
0x000055555555517a	26	  return myglob++;	/* ARRIVED IN CALLEE */
(gdb) stepi
27	}			/* RETURN FROM CALLEE */
(gdb) stepi
0x0000555555555181	27	}			/* RETURN FROM CALLEE */
(gdb) stepi
main () at /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c:81
81	   callee();	/* NEXTI TEST */
(gdb) PASS: gdb.reverse/step-reverse.exp: stepi back from function call
set exec-dir reverse
(gdb) PASS: gdb.reverse/step-reverse.exp: set reverse execution
stepi
0x0000555555555181 in callee () at /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c:27
27	}			/* RETURN FROM CALLEE */
(gdb) stepi
27	}			/* RETURN FROM CALLEE */
(gdb) stepi
0x000055555555517a	26	  return myglob++;	/* ARRIVED IN CALLEE */
(gdb) stepi
0x0000555555555177	26	  return myglob++;	/* ARRIVED IN CALLEE */
(gdb) stepi
26	  return myglob++;	/* ARRIVED IN CALLEE */
(gdb) PASS: gdb.reverse/step-reverse.exp: reverse stepi thru function return
stepi
0x000055555555516e	25	int callee() {		/* ENTER CALLEE */
(gdb) stepi
0x000055555555516d	25	int callee() {		/* ENTER CALLEE */
(gdb) stepi
25	int callee() {		/* ENTER CALLEE */
(gdb) stepi
0x000055555555524d in main () at /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c:78
78	   callee();	/* STEPI TEST */
(gdb) stepi
78	   callee();	/* STEPI TEST */
(gdb) PASS: gdb.reverse/step-reverse.exp: reverse stepi from a function call
stepi
77	   a[5] = a[3] - a[4]; /* FINISH TEST */
(gdb) PASS: gdb.reverse/step-reverse.exp: simple reverse stepi
step
77	   a[5] = a[3] - a[4]; /* FINISH TEST */
(gdb) FAIL: gdb.reverse/step-reverse.exp: reverse step into fn call
step
callee () at /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c:27
27	}			/* RETURN FROM CALLEE */
(gdb) FAIL: gdb.reverse/step-reverse.exp: reverse step out of called fn
next
26	  return myglob++;	/* ARRIVED IN CALLEE */
(gdb) FAIL: gdb.reverse/step-reverse.exp: reverse next over call
next
main () at /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c:74
74	   callee();	/* STEP INTO THIS CALL */
(gdb) FAIL: gdb.reverse/step-reverse.exp: reverse next over recursion
set exec-dir forward
(gdb) PASS: gdb.reverse/step-reverse.exp: forward again to test recursion
next
77	   a[5] = a[3] - a[4]; /* FINISH TEST */
(gdb) FAIL: gdb.reverse/step-reverse.exp: reverse next over recursion again
set exec-dir reverse
(gdb) PASS: gdb.reverse/step-reverse.exp: reverse again to test recursion
step
callee () at /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c:27
27	}			/* RETURN FROM CALLEE */
(gdb) FAIL: gdb.reverse/step-reverse.exp: enter recursive function
next
26	  return myglob++;	/* ARRIVED IN CALLEE */
(gdb) next
main () at /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.c:74
74	   callee();	/* STEP INTO THIS CALL */
(gdb) next
71	   callee();	/* NEXT OVER THIS CALL */
(gdb) next
68	   recursive_callee (32); /* NEXT OVER THIS RECURSION */
(gdb) PASS: gdb.reverse/step-reverse.exp: step over recursion inside the recursion
step 3
63	   x = x + 3;	/* REVERSE STEP TEST 1 */
(gdb) PASS: gdb.reverse/step-reverse.exp: reverse step test 1
next 2
61	   z = 3;	/* REVERSE NEXT TEST 1 */
(gdb) PASS: gdb.reverse/step-reverse.exp: reverse next test 1
step
60	   y = 2;	/* STEP TEST 1 */
(gdb) PASS: gdb.reverse/step-reverse.exp: reverse step test 2
next
59	   x = 1;	/* NEXT TEST 1 */
(gdb) PASS: gdb.reverse/step-reverse.exp: reverse next test 2
testcase /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.reverse/step-reverse.exp completed in 0 seconds

		=== gdb Summary ===

# of expected passes		23
# of unexpected failures	6
Executing on host: /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/../../gdb/gdb -nw -nx -iex "set height 0" -iex "set width 0" -data-directory /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/../data-directory --version    (timeout = 300)
builtin_spawn -ignore SIGHUP /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/../../gdb/gdb -nw -nx -iex set height 0 -iex set width 0 -data-directory /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/../data-directory --version
GNU gdb (GDB) 13.0.50.20220930-git
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
/home/pedro/gdb/binutils-gdb/build/gdb/gdb version  13.0.50.20220930-git -nw -nx -iex "set height 0" -iex "set width 0" -data-directory /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/../data-directory 

runtest completed at Fri Sep 30 17:52:30 2022

  reply	other threads:[~2022-09-30 18:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-31 12:07 [PATCH v3 0/2] Fix reverse nexting over recursions Bruno Larsen
2022-08-31 12:07 ` [PATCH v3 1/2] Change calculation of frame_id by amd64 epilogue unwinder Bruno Larsen
2022-08-31 12:07 ` [PATCH v3 2/2] gdb/reverse: Fix stepping over recursive functions Bruno Larsen
2022-09-30 18:28   ` Pedro Alves [this message]
2022-10-04 16:40     ` Bruno Larsen
2022-09-14 13:16 ` [Ping][PATCH v3 0/2] Fix reverse nexting over recursions Bruno Larsen
2022-09-22 14:13   ` [PINGv2][PATCH " Bruno Larsen
2022-09-29  7:02     ` [PINGv3][PATCH " Bruno Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b2701f2-3624-75ca-6af5-02abb6126804@palves.net \
    --to=pedro@palves.net \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).