From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [gdb/testsuite] Add gdb.base/unwind-on-each-insn-{amd64, i386}.exp
Date: Fri, 27 Jan 2023 21:50:54 +0100 [thread overview]
Message-ID: <2b6ce3a3-7e68-7dbe-14ac-1fced7f0091f@suse.de> (raw)
In-Reply-To: <875yctrw9w.fsf@tromey.com>
On 1/26/23 19:22, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Tom> I did wonder about eliminating commonality between
> Tom> unwind-on-each-insn-i386.exp and unwind-on-each-insn-amd64.exp, but
> Tom> decided it was not worth the trouble.
>
> One thing some gdb.arch tests do is test the arch and then set some
> variables based on that. So I guess if you wanted there could be a
> single .exp file and not the .exp/.tcl split.
I could merge unwind-on-each-insn-i386.exp and
unwind-on-each-insn-amd64.exp, but I still would require the split
because also unwind-on-each-insn.exp use the .tcl file.
Anyway, I've been playing with the idea of enabling
unwind-on-each-insn-i386.exp on x86_64, using -m32 (but that might be
part of a larger exercise, extending to all gdb.arch i386 test-cases).
And for that I'd need unwind-on-each-insn-i386.exp separate from
unwind-on-each-insn-amd64.exp.
So, for now I'm keeping this as is.
Thanks,
- Tom
prev parent reply other threads:[~2023-01-27 20:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 20:09 [PATCH] [gdb/testsuite] Add gdb.base/unwind-on-each-insn-{amd64,i386}.exp Tom de Vries
2023-01-26 16:21 ` [PATCH] [gdb/testsuite] Add gdb.base/unwind-on-each-insn-{amd64, i386}.exp Tom de Vries
2023-01-26 18:22 ` Tom Tromey
2023-01-27 20:50 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b6ce3a3-7e68-7dbe-14ac-1fced7f0091f@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).