From: Pedro Alves <pedro@palves.net>
To: Mikael Szreder <miksz574@student.liu.se>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb/solib-svr4.c: Fix segfault caused by NULL pointer
Date: Fri, 4 Mar 2022 16:13:35 +0000 [thread overview]
Message-ID: <2ba4e47d-553c-9fc4-cc5a-7d1f88e2928b@palves.net> (raw)
In-Reply-To: <DU0P191MB20333F5BF639A7C4AFBAE4A8A5059@DU0P191MB2033.EURP191.PROD.OUTLOOK.COM>
On 2022-03-04 10:54, Mikael Szreder via Gdb-patches wrote:
> + if (interp_name_holder && interp_name_holder->size() != 0)
It's preferred to write '!empty ()' instead of 'size () != 0'.
prev parent reply other threads:[~2022-03-04 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 10:54 Mikael Szreder
2022-03-04 12:35 ` Bruno Larsen
2022-03-04 14:35 ` Tom Tromey
2022-03-04 16:13 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ba4e47d-553c-9fc4-cc5a-7d1f88e2928b@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=miksz574@student.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).