Re: [PATCH] gdb/solib-svr4.c: Fix segfault caused by NULL pointer

[Tom Tromey <tom@tromey.com>]

>>>>> "Mikael" == Mikael Szreder via Gdb-patches <gdb-patches@sourceware.org> writes:

Mikael> Inside the function 'enable_break' there is a call to 'find_program_interpreter'.
Mikael> This function returns an empty vector when an ELF file does not contain
Mikael> an interpreter because the function 'read_program_header' header
Mikael> returns an empty vector on failure.

read_program_header also returns a gdb::optional, so it seems to me that
something else must be going on here.  Like, maybe the data that is read
from the target has 0 length?

I think the patch is basically ok, with one nit:

+  if (interp_name_holder && interp_name_holder->size() != 0)

... gdb style is a space before the "(".

However, I'd like to understand the underlying issue correctly first, so
at least the commit message can be updated -- or perhaps a test case added.

thanks,
Tom